Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we set the AWS region. #19178

Merged
merged 1 commit into from
May 28, 2023
Merged

Ensure we set the AWS region. #19178

merged 1 commit into from
May 28, 2023

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented May 28, 2023

This fix was found by Benjy in #18088 and here it just gets applied in
a missed spot.

@jsirois
Ensure we set the AWS region.
4791402 
This fix was found by Benjy in pantsbuild#18088 and here it just gets applied in
a missed spot.
@jsirois jsirois added the category:internal CI, fixes for not-yet-released features, etc. label May 28, 2023
@jsirois
Copy link
Contributor Author

jsirois commented May 28, 2023

Tested this doesn't break the script via:

$ AWS_ACCESS_KEY_ID=*** AWS_SECRET_ACCESS_KEY=*** build-support/bin/create_s3_index_file.sh a9e570fb1cae4e10ebfb9039f163841e59236f73
+ REGION=us-east-1
+ SHA=a9e570fb1cae4e10ebfb9039f163841e59236f73
+ WHEEL_DIR=binaries.pantsbuild.org/wheels/pantsbuild.pants
++ aws_s3 ls s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/
++ aws --region=us-east-1 s3 ls s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/
++ awk '{print $2}'
++ tr -d /
+ VERSION=2.18.0.dev0+gita9e570fb
+ VERSION_DIR=binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb
+ aws_s3 cp --acl=public-read --content-type=text/html - s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/index.html
+ aws --region=us-east-1 s3 cp --acl=public-read --content-type=text/html - s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/index.html
++ aws_s3 ls s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/
++ grep '\.whl'
++ aws --region=us-east-1 s3 ls s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/
++ awk '{print $4}'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-linux_aarch64.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants-2.18.0.dev0%2Bgita9e570fb-cp39-cp39-linux_aarch64.whl">pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-linux_aarch64.whl</a>\n'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-linux_x86_64.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants-2.18.0.dev0%2Bgita9e570fb-cp39-cp39-linux_x86_64.whl">pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-linux_x86_64.whl</a>\n'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-macosx_10_15_x86_64.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants-2.18.0.dev0%2Bgita9e570fb-cp39-cp39-macosx_10_15_x86_64.whl">pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-macosx_10_15_x86_64.whl</a>\n'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-macosx_11_0_arm64.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants-2.18.0.dev0%2Bgita9e570fb-cp39-cp39-macosx_11_0_arm64.whl">pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-macosx_11_0_arm64.whl</a>\n'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants.testutil-2.18.0.dev0+gita9e570fb-py3-none-any.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants.testutil-2.18.0.dev0%2Bgita9e570fb-py3-none-any.whl">pantsbuild.pants.testutil-2.18.0.dev0+gita9e570fb-py3-none-any.whl</a>\n'

@jsirois jsirois merged commit a34feab into pantsbuild:main May 28, 2023
@jsirois jsirois deleted the publish-job/fix branch May 28, 2023 01:32
@stuhood stuhood added this to the 2.17.x milestone May 28, 2023
github-actions bot pushed a commit that referenced this pull request May 28, 2023
@jsirois @WorkerPants
Ensure we set the AWS region. (#19178)
0bc6ed7 
This fix was found by Benjy in #18088 and here it just gets applied in
a missed spot.
stuhood pushed a commit that referenced this pull request May 30, 2023
@WorkerPants @jsirois
Ensure we set the AWS region. (Cherry-pick of #19178) (#19181)
e99dda5 
This fix was found by Benjy in #18088 and here it just gets applied in
a missed spot.

Co-authored-by: John Sirois <john.sirois@gmail.com>
@stuhood stuhood mentioned this pull request Jun 1, 2023
Merged
@wisechengyi wisechengyi mentioned this pull request Jun 3, 2023
Merged
wisechengyi added a commit that referenced this pull request Jun 4, 2023
@wisechengyi
Prep 1.28.0.dev1 (#19233)
46b9518 
### Internal

* upgrade to Rust v1.70.0
([#19228](#19228))

* Remove the last mentions of NO_TOOL_LOCKFILE.
([#19229](#19229))

* Upgrade Helm unittest
([#19220](#19220))

* Prepare `2.17.0rc0`.
([#19226](#19226))

* Use a trait for remote action result caching
([#19097](#19097))

* Port `Field` to Rust
([#19143](#19143))

* Upgrade `pyo3` to `0.19`.
([#19223](#19223))

* Prepare `2.16.0rc5`.
([#19221](#19221))

* internal: Create dep inference request type
([#19001](#19001))

* Avoid requiring Python when trying to install Python (using Pyenv)
([#19208](#19208))

* Fix secondary ownership warning semantics
([#19191](#19191))

* Bump os_pipe from 1.1.3 to 1.1.4 in /src/rust/engine
([#19202](#19202))

* Include committer date in local version identifier of unstable builds
([#19179](#19179))

* Ensure we set the AWS region.
([#19178](#19178))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@stuhood stuhood Awaiting requested review from stuhood

@illicitonion illicitonion Awaiting requested review from illicitonion

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
2.17.x
Development

Successfully merging this pull request may close these issues.
4 participants
@jsirois @benjyw @stuhood @WorkerPants