-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of additional files in Helm unit tests #19263
Improve handling of additional files in Helm unit tests #19263
Conversation
User that reported the linked bug just confirmed that the undocumented approach of using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update!
I offer some language/typo tweaks and suggestions, feel free to take as needed.
One thing to remember though is that readme.com renders "soft" linebreaks in the markdown source as hard linebreaks. So until we fix that (or, ideally, move off readme.com) we have to keep entire paragraphs on a single line. So I recommend that you manually reconnect lines that are broken in the source but shouldn't be in the rendered source. For example, lines 163+164 should probably be joined.
I'll wait for this before cutting 2.16.x rc. |
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
thanks for the suggestions, just removed the soft line breaks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane
…9263) Fixes handling of additional files in Helm unit tests
…9263) Fixes handling of additional files in Helm unit tests
…9263) Fixes handling of additional files in Helm unit tests
…9263) Fixes handling of additional files in Helm unit tests
This updates `changelog.py` to write the (non-internal) changes to the relevant release notes file directly, rather than requiring a human to copy-paste it in. For now, the file is just mutated, without committing. The internal changes are still printed for the human to deal with. For instance, `pants run src/python/pants_release/changelog.py -- --prior 2.18.0.dev1 --new 2.18.0.dev2` adds a new section to `src/python/pants/notes/2.18.x.md`: ```diff diff --git a/src/python/pants/notes/2.18.x.md b/src/python/pants/notes/2.18.x.md index e648a4525c..d6668a24b1 100644 --- a/src/python/pants/notes/2.18.x.md +++ b/src/python/pants/notes/2.18.x.md @@ -1,5 +1,35 @@ # 2.18.x Release Series +## 2.18.0.dev2 (Jun 14, 2023) + +### New Features + +* Include complete platforms for FaaS environments for more reliable building ([#19253](#19253)) + +* Add experimental support for Rustfmt ([#18842](#18842)) + +* Helm deployment chart field ([#19234](#19234)) + +### Plugin API Changes + +* Replace `include_special_cased_deps` flag with `should_traverse_deps_predicate` ([#19272](#19272)) + +### Bug Fixes + +* Raise an error if isort can't read a config file ([#19294](#19294)) + +* Improve handling of additional files in Helm unit tests ([#19263](#19263)) + +* Add taplo to the release ([#19258](#19258)) + +* Handle `from foo import *` wildcard imports in Rust dep inference parser ([#19249](#19249)) + +* Support usage of `scala_artifact` addresses in `scalac_plugin` targets ([#19205](#19205)) + +### Performance + +* `scandir` returns `Stat`s relative to its directory. ([#19246](#19246)) + ## 2.18.0.dev1 (Jun 02, 2023) ### New Features ``` This also moves it into the new `pants_release` root, adds some basic tests, and has it fetch the relevant branch directly, rather than prompting the user to do so. It also pulls out a `git.py` support module with helpers for exec-ing `git` as an external process. The commits are individually reviewable. This is a step towards automating more of the "start release" process, per #19279. After this core refactoring of the functionality, I think the next step is to combine it with the CONTRIBUTORS update and version bumping, and then after that string it all together on CI so that starting a release is fully automated.
This comment was marked as outdated.
This comment was marked as outdated.
I ran @WorkerPants on this PR not realizing it had already been cherry-picked. Thats why it failed. Please ignore 👍 (FWIW I did so because the |
Closes #19257.
Fixes handling of additional files in Helm unit tests. Adds test cases to Pants in which we can verify that Helm unit test can use additional files via the
resources
,files
andrelocated_files
targets.