Don't gpg-sign PyPI uploads in our release process. #19287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 5/23/2023 PyPI ignores these signatures, and the releaser gets an email saying as much. See here for details: https://blog.pypi.org/posts/2023-05-23-removing-pgp/ Also: - Don't attempt to run the release pex for validation, as it only runs on x86_64 (at least currently), so that validation fails on Apple Silicon machines, which are increasingly commonly used by releasers. - Some tweaks to the release instructions.
Eric-Arellano
approved these changes
Jun 10, 2023
| @@ -94,7 +94,7 @@ Update the release page in `src/python/pants/notes` for this release series, e.g | |||
|
|
|||
| Run `git fetch --all --tags` to be sure you have the latest release tags available locally. | |||
|
|
|||
| From the `main` branch, run `pants run build-support/bin/changelog.py -- --prior 2.9.0.dev0 --new 2.9.0.dev1` with the relevant versions. | |||
| From the `main` branch, run `./pants run build-support/bin/changelog.py -- --prior 2.9.0.dev0 --new 2.9.0.dev1` with the relevant versions. | |||
There was a problem hiding this comment.
I think ./pants is still the officially sanctioned way to run Pants in the pantsbuild repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 5/23/2023 PyPI ignores these signatures, and the
releaser gets an email saying as much.
See here for details:
https://blog.pypi.org/posts/2023-05-23-removing-pgp/
Also:
runs on x86_64 (at least currently), so that validation fails on
Apple Silicon machines, which are increasingly commonly used by releasers.