A few fixes for the auto-cherry-pick script

[thejcannon]

A few fixes:

• Stop using if: always(). As I'm understanding it, this will force the job to run, even if prerequisites didn't run (I'm thinking this is for, like critical teardown jobs/steps). Instead use if: success() || failure(), which is suggested in the docs. As I understand there are (at least?) 4 states: success, failure, skipped, and cancelled.
• Used upstream github-script since we no longer talk to the web
  • This fixes Auto cherry picker fails with "Token passed to createTokenAuth is not a string" #19305 (I think)
• Pass a dummy PAT
• Add a new test for PR event
• Add a new xfail test that should be testing the bugfix, but unfortunately act has a bug

So, can't test that this fixes it, but the suggestion comes from GitHub directly: https://docs.github.com/en/actions/learn-github-actions/expressions#always

[huonw]

Is this allow-empty-token now unneeded (here and above)?

[thejcannon]

👍

[huonw]

Approved conditional on satisfying yourself that the root cause of the token-related error is fixed here, and we're not just papering over it in the case of a PR without cherry-picks. (I think the change to avoid always makes sense though, even if there's additional changes required.)

[thejcannon]

Yeah sorry, I shouldn't make PRs before bed 😂

I'll switch the PR description to be accurate. The changing to upstream github-script is the actual bugfix. The always() also has to be in this PR (or an earlier one) so we don't start commenting on every PR.

[thejcannon]

Seems to have worked 😄 https://github.com/pantsbuild/pants/actions/runs/5269341468

[thejcannon]

OK poking around the GH API, there seem to be at least the four states mentioned above. 👍

[huonw]

The changing to upstream github-script is the actual bugfix

👍

The always() also has to be in this PR (or an earlier one) so we don't start commenting on every PR

👍