Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto-cherry-pick issues discovered when run #19312

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Fix auto-cherry-pick issues discovered when run #19312

merged 5 commits into from
Jun 14, 2023

Conversation

thejcannon
Copy link
Member

@thejcannon thejcannon commented Jun 14, 2023 •
edited
Loading

See #19271 (comment) for those issues.

Namely:

  • Add continue-on-error to the cherry pick job so that other cherry-picks don't get cancelled if one fails
  • Switch if: success() || failure() to now checking if prerequisites job succeeded
    • That way we don't double-comment if that job fails
  • Fix the run link
  • Add a comment (on failure to remove the needs-cherrypick label)

@thejcannon thejcannon added the category:internal CI, fixes for not-yet-released features, etc. label Jun 14, 2023
@thejcannon thejcannon requested a review from huonw June 14, 2023 17:34
@thejcannon thejcannon merged commit eff4fe9 into main Jun 14, 2023
@thejcannon thejcannon deleted the jcannon/cherriesroundwhatever branch June 14, 2023 21:05
@Eric-Arellano Eric-Arellano mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw approved these changes

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thejcannon @huonw