Mark python_aws_lambda_layer as packageable #19562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In yet more follow up to #19123 and #19550 for #18880, this ensures the
PythonAwsLambdaLayerFieldSetis part of thePackageFieldSetunion, so thatpants package path/to:some-layeractually works.I clearly didn't test this properly in #19123 or #19550, but now I have: in a separate repo
PANTS_SOURCE=~/... pants package path/to:some-layerproducesdist/path.to/some-layer.zip, with the expected contents. 🎉