-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch google artifact registry gotcha #19568
Conversation
The command referenced in the docker config is `gcloud` which is a suffix for `docker-credential-gcloud`. This can be a significant gotcha when first trying to set up docker publishing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the Pantsbuild Community. This looks like your first PR here.
We are so grateful for each an every contribution, big or small.
So thanks for spending your time and energy making this project better.
If you haven't gotten a reply in a week, feel free to gently comment "bump" to ping the project admins.
If you haven't already, feel free to come say hi on Slack.
If you have questions, or just want to surface this PR, check out the #development
channel.
(If you want to check it out without logging in, check out our Linen mirror)
Thanks again for this PR, and we'll be on the lookout for your next one 😄!
No need, thanks. I'll close that one out, since the fix will come from a doc regen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The command referenced in the docker config is `gcloud` which is a suffix for `docker-credential-gcloud`. This can be a significant gotcha when first trying to set up docker publishing.
The command referenced in the docker config is `gcloud` which is a suffix for `docker-credential-gcloud`. This can be a significant gotcha when first trying to set up docker publishing.
The command referenced in the docker config is `gcloud` which is a suffix for `docker-credential-gcloud`. This can be a significant gotcha when first trying to set up docker publishing. Since I was asked to submit this as a PR, do you also want me to update the relevant "suggest edit" section? Co-authored-by: Christoph Proeschel <proeschel.christoph@gmail.com>
The command referenced in the docker config is `gcloud` which is a suffix for `docker-credential-gcloud`. This can be a significant gotcha when first trying to set up docker publishing. Since I was asked to submit this as a PR, do you also want me to update the relevant "suggest edit" section? Co-authored-by: Christoph Proeschel <proeschel.christoph@gmail.com>
The command referenced in the docker config is
gcloud
which is a suffix fordocker-credential-gcloud
. This can be a significant gotcha when first trying to set up docker publishing.Since I was asked to submit this as a PR, do you also want me to update the relevant "suggest edit" section?