Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch google artifact registry gotcha #19568

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Catch google artifact registry gotcha #19568

merged 1 commit into from
Aug 8, 2023

Conversation

chrismatix
Copy link
Contributor

@chrismatix chrismatix commented Aug 8, 2023

The command referenced in the docker config is gcloud which is a suffix for docker-credential-gcloud. This can be a significant gotcha when first trying to set up docker publishing.

Since I was asked to submit this as a PR, do you also want me to update the relevant "suggest edit" section?

The command referenced in the docker config is `gcloud` which is a suffix for `docker-credential-gcloud`. This can be a significant gotcha when first trying to set up docker publishing.
Copy link
Member

@WorkerPants WorkerPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Pantsbuild Community. This looks like your first PR here.

We are so grateful for each an every contribution, big or small.
So thanks for spending your time and energy making this project better.

If you haven't gotten a reply in a week, feel free to gently comment "bump" to ping the project admins.

If you haven't already, feel free to come say hi on Slack.

If you have questions, or just want to surface this PR, check out the #development channel.
(If you want to check it out without logging in, check out our Linen mirror)

Thanks again for this PR, and we'll be on the lookout for your next one 😄!

@benjyw
Copy link
Contributor

benjyw commented Aug 8, 2023

Since I was asked to submit this as a PR, do you also want me to update the relevant "suggest edit" section?

No need, thanks. I'll close that one out, since the fix will come from a doc regen.

Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benjyw benjyw added this to the 2.16.x milestone Aug 8, 2023
@benjyw benjyw merged commit f48cbc6 into pantsbuild:main Aug 8, 2023
25 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 8, 2023
The command referenced in the docker config is `gcloud` which is a
suffix for `docker-credential-gcloud`. This can be a significant gotcha
when first trying to set up docker publishing.
github-actions bot pushed a commit that referenced this pull request Aug 8, 2023
The command referenced in the docker config is `gcloud` which is a
suffix for `docker-credential-gcloud`. This can be a significant gotcha
when first trying to set up docker publishing.
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.16.x

Successfully opened #19569.

✔️ 2.17.x

Successfully opened #19570.


Thanks again for your contributions!

🤖 Beep Boop here's my run link

benjyw pushed a commit that referenced this pull request Aug 8, 2023
The command referenced in the docker config is `gcloud` which is a
suffix for `docker-credential-gcloud`. This can be a significant gotcha
when first trying to set up docker publishing.

Since I was asked to submit this as a PR, do you also want me to update
the relevant "suggest edit" section?

Co-authored-by: Christoph Proeschel <proeschel.christoph@gmail.com>
benjyw pushed a commit that referenced this pull request Aug 8, 2023
The command referenced in the docker config is `gcloud` which is a
suffix for `docker-credential-gcloud`. This can be a significant gotcha
when first trying to set up docker publishing.

Since I was asked to submit this as a PR, do you also want me to update
the relevant "suggest edit" section?

Co-authored-by: Christoph Proeschel <proeschel.christoph@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants