Scala: support Enums in dependency inference #19588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
reviewed
Aug 11, 2023
tdyas
approved these changes
Aug 12, 2023
|
I edited the PR description to not include questions (since it will become the commit message). |
|
As for the question about whether to set |
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Aug 13, 2023
Dependency inference for Scala does not currently detect Enum types. This PR fixes that. The newer Scalameta release also adds support for the `fewerBraces` Syntax in Scala 3.3.0. --------- Co-authored-by: Matthias Berndt <matthias.berndt@ttmzero.com>
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Aug 13, 2023
Dependency inference for Scala does not currently detect Enum types. This PR fixes that. The newer Scalameta release also adds support for the `fewerBraces` Syntax in Scala 3.3.0. --------- Co-authored-by: Matthias Berndt <matthias.berndt@ttmzero.com>
tdyas
added a commit
that referenced
this pull request
Aug 13, 2023
…19594) Dependency inference for Scala does not currently detect Enum types. This PR fixes that. The newer Scalameta release also adds support for the `fewerBraces` Syntax in Scala 3.3.0. --------- Co-authored-by: Matthias Berndt <matthias_berndt@gmx.de> Co-authored-by: Matthias Berndt <matthias.berndt@ttmzero.com>
tdyas
added a commit
that referenced
this pull request
Aug 13, 2023
…19593) Dependency inference for Scala does not currently detect Enum types. This PR fixes that. The newer Scalameta release also adds support for the `fewerBraces` Syntax in Scala 3.3.0. --------- Co-authored-by: Matthias Berndt <matthias_berndt@gmx.de> Co-authored-by: Matthias Berndt <matthias.berndt@ttmzero.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency inference for Scala does not currently detect Enum types. This PR fixes that. The newer Scalameta release also adds support for the
fewerBracesSyntax in Scala 3.3.0.