Require scie-pants 0.9.2 or newer, for new distribution model (Cherry-pick of #19654) #19694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates Pants to require and check for the scie-pants launcher binary version: we need version 0.9 or earlier, to have support for the new distribution model. This syncs with pantsbuild/scie-pants#246 (which will become scie-pants 0.9.2 / 0.9.3), which sets the `SCIE_PANTS_VERSION` environment variable when running pants. This will be cherry-picked back as far as we support, to help users upgrade their launcher earlier. Fixes #19600
huonw
approved these changes
Aug 29, 2023
huonw
added a commit
that referenced
this pull request
Jan 15, 2024
This replaces the over-complicated address URI scheme-based look-up from #19827 for deciding on which provider to use with just a normal option `[GLOBAL].remote_provider`. This defaults to `reapi`, to preserve the current (stable) behaviour. That is, now, one can set: ```toml [GLOBAL] remote_provider = "experimental-file" remote_store_address = "file:///..." ``` Or similar. Another item in #19694 The commits are somewhat usefully broken up for review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Pants to require and check for the scie-pants launcher binary version: we need version 0.9 or later, to have support for the new distribution model. This syncs with pantsbuild/scie-pants#246 (which will become scie-pants 0.9.2 / 0.9.3), which sets the
SCIE_PANTS_VERSIONenvironment variable when running pants.This will be cherry-picked back as far as we support, to help users upgrade their launcher earlier.
Fixes #19600