Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin CI to Python 3.9.18 specifically #19783

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cache_comparison.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 10
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -363,10 +363,10 @@ jobs:
with:
fetch-depth: '0'
ref: ${{ needs.release_info.outputs.build-ref }}
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Generate announcement
Expand Down
56 changes: 28 additions & 28 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 10
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Install Protoc
uses: arduino/setup-protoc@9b1ee5b22b0a3f1feb8c2ff99b32c89b3c3191e9
with:
Expand Down Expand Up @@ -215,10 +215,10 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 10
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Install Protoc
uses: arduino/setup-protoc@9b1ee5b22b0a3f1feb8c2ff99b32c89b3c3191e9
with:
Expand Down Expand Up @@ -611,10 +611,10 @@ jobs:
\ --max_size 30\necho \"PANTS_REMOTE_STORE_ADDRESS=grpc://localhost:9092\" >> \"$GITHUB_ENV\"\necho\
\ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\
\n"
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Download native binaries
uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -786,10 +786,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -877,10 +877,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -968,10 +968,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -1059,10 +1059,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -1150,10 +1150,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -1241,10 +1241,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -1332,10 +1332,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -1423,10 +1423,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -1514,10 +1514,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -1605,10 +1605,10 @@ jobs:
echo "${HOME}/.thrift" >> $GITHUB_PATH

'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down Expand Up @@ -1663,10 +1663,10 @@ jobs:
with:
distribution: adopt
java-version: '11'
- name: Set up Python 3.9
- name: Set up Python 3.9.18
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: 3.9.18
- name: Expose Pythons
uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe
- name: Download native binaries
Expand Down
6 changes: 3 additions & 3 deletions src/python/pants_release/generate_github_workflows.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ def hash_files(path: str) -> str:
f"{NATIVE_FILES_COMMON_PREFIX}/engine/internals/native_engine.so.metadata",
]

# We don't specify a patch version so that we get the latest, which comes pre-installed:
# https://github.com/actions/setup-python#available-versions-of-python
PYTHON_VERSION = "3.9"
# We specify a patch version because Github runners upgrade their versions incrementally: some
# runners might be on 3.9.17 while others are on 3.9.18
PYTHON_VERSION = "3.9.18"

DONT_SKIP_RUST = "needs.classify_changes.outputs.rust == 'true'"
DONT_SKIP_WHEELS = "needs.classify_changes.outputs.release == 'true'"
Expand Down