Split fromfile support into its own submodule #20807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
approved these changes
Apr 18, 2024
benjyw
added a commit
that referenced
this pull request
Apr 18, 2024
As with #20807, this is another preliminary change to support fromfile paths being relative to the buildroot. This change introduces a FromfileExpander struct, and moves the expansion logic from free functions to struct methods. The free functions are then reimplemented as calls into these methods, to avoid perturbing calling code. A followup change will plumb instances of this struct wherever needed, and remove the free functions. Another followup change will introduce the buildroot context to this struct, to finally achieve the underlying functionality change. This change is just a refactoring, to make the subsequent changes easier to grok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: Option @fromfile paths are intended to be relative
to the buildroot, not the cwd. This will require us to plumb
buildroot information through in several places.
This change is prep work for that change, and is straightforward
and technical, despite the diff stats: It just splits fromfile support
out into its own submodule. This will make the subsequent changes
easier to grok.
The new fromfile.rs and fromfile_tests.rs contain code moved
from parser.rs and parser_tests.rs, with no functionality changes.
The other diffs are just import changes.