Caching for Terraform! #21221
Merged
Caching for Terraform! #21221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilatomic
added
category:new feature
backend: Terraform
lilatomic
force-pushed
the
terraform/better-cache
branch
from
091b1a2 to
c7f1b46
Compare
tdyas
approved these changes
Aug 3, 2024
|
|
||
| path = [] | ||
| user_path = env.get("PATH") | ||
| if user_path is not None: |
There was a problem hiding this comment.
Edge case, but you probably don't want to append a blank PATH value either. Maybe just use if user_path: here then?
There was a problem hiding this comment.
good point! We should centralise merging envvars at some point, I think there are a few subsystems that allow a passthrough of envvars in some way
There was a problem hiding this comment.
I added a common env vars helper in the adhoc / shell backends via the prepare_env_vars function.
There was a problem hiding this comment.
Parts of that method might be useful elsewhere in the future.
lilatomic
force-pushed
the
terraform/better-cache
branch
from
23644ce to
6a77c94
Compare
`terraform providers mirror` is really intended to easily spin up a network mirror, not so much for cacheing
allows `init` to cache plugins automatically
lilatomic
force-pushed
the
terraform/better-cache
branch
from
6a77c94 to
5ea8e70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds caching for Terraform! specifically the providers, which is the thing you need to download. It uses the provider cache.
Pulling in "hashicorp/azurerm" "hashicorp/azuread" (total 200M) goes from 22s to 2s (33s to 13s including pants startup).