Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move BSP QueryRule registration out of core rules #21311

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Aug 15, 2024

The refactor in #20913 to move BSP out of the core rules (via the new AuxiliaryGoal support) did not move the registration of BSP-related QueryRules out of the core rules.

This PR remedies that oversight by moving the QueryRule registration to the applicable BSP backends.

@tdyas tdyas added category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes labels Aug 15, 2024
@tdyas tdyas requested review from benjyw and sureshjoshi August 15, 2024 16:10
@tdyas tdyas merged commit 6bdc114 into pantsbuild:main Aug 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants