Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the major version of golang at package time #21523

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Use the major version of golang at package time #21523

merged 3 commits into from
Nov 6, 2024

Conversation

SvenW
Copy link
Contributor

@SvenW SvenW commented Oct 14, 2024

Should hopefully fix #20723

@SvenW SvenW force-pushed the fix/gomod branch 2 times, most recently from 421f699 to 61a2c18 Compare October 15, 2024 06:41
@tgolsson tgolsson added backend: Go Go backend-related issues category:bugfix Bug fixes for released features labels Oct 16, 2024
@SvenW
Copy link
Contributor Author

SvenW commented Oct 18, 2024

@tgolsson how should I label the PR in order to fix the check Ensure PR has release notes

@tgolsson
Copy link
Contributor

  • add release notes to the appropriate file in docs/notes

seems like the appropriate resolution here! https://github.com/pantsbuild/pants/blob/main/docs/notes/2.24.x.md would be the file in this case.

@tdyas tdyas self-requested a review October 21, 2024 09:38
huonw
huonw reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it seems reasonable on the surface other than a slight resiliency question.

src/python/pants/backend/go/util_rules/goroot.py Outdated Show resolved Hide resolved
@huonw
Copy link
Contributor

huonw commented Nov 2, 2024

@tdyas I noticed you self-requested a review, are you still planning to take a look?

@tdyas
Copy link
Contributor

tdyas commented Nov 5, 2024

@tdyas I noticed you self-requested a review, are you still planning to take a look?

Yes. I just approved the CI run, so will likely approve if no issues with CI.

@huonw
Copy link
Contributor

huonw commented Nov 6, 2024

Looks green!

@tdyas tdyas added this to the 2.22.x milestone Nov 6, 2024
@tdyas tdyas merged commit 92ea576 into pantsbuild:main Nov 6, 2024
24 checks passed
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.22.x

Successfully opened #21617.

✔️ 2.23.x

Successfully opened #21618.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

tdyas added a commit that referenced this pull request Nov 6, 2024
@WorkerPants @SvenW
@huonw @tdyas
Use the major version of golang at package time (Cherry-pick of #21523)…
a89be49 
… (#21618)

Should hopefully fix #20723

---------

Co-authored-by: Sven Widén <sven.widen@gmail.com>
Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
Co-authored-by: Tom Dyas <tom.dyas@gmail.com>
tdyas added a commit that referenced this pull request Nov 6, 2024
@WorkerPants @SvenW
@huonw @tdyas
Use the major version of golang at package time (Cherry-pick of #21523)…
204bdeb 
… (#21617)

Should hopefully fix #20723

---------

Co-authored-by: Sven Widén <sven.widen@gmail.com>
Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
Co-authored-by: Tom Dyas <tom.dyas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw left review comments

@tdyas tdyas tdyas approved these changes

Assignees
No one assigned
Labels
backend: Go Go backend-related issues category:bugfix Bug fixes for released features
Projects
None yet
Milestone
2.22.x
Development

Successfully merging this pull request may close these issues.

compile: invalid value "go1.21.7" for -lang: should be something like "go1.12"
5 participants
@SvenW @tgolsson @huonw @tdyas @WorkerPants