use GILProtected to synchronize access to various pyclass types
#21670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
added
category:internal
tdyas
force-pushed
the
pyo3/gilprotected-1
branch
from
cefcb63 to
7095454
Compare
tdyas
changed the title
GILProtected to synchronize access to various generator call structsGILProtected to synchronize access to various pyclass types
This was referenced Nov 19, 2024
benjyw
approved these changes
Nov 19, 2024
tdyas
added a commit
that referenced
this pull request
Nov 21, 2024
[Upgrade to v0.23.x of the `pyo3` crate](#21671): - Functions in PyO3 with `_bound` suffixes existed in PyO3 only for easing migration to the `Bound` API. They are deprecated now and new methods without the `_bound` suffixes have been re-introduced in PyO3. This PR renames call sites accordingly and updates code to also reflect that some of the new APIs (e.g., `PyTuple::new`) are now fallible. - The `IntoPy` and `ToPyObject` traits are deprecated in favor of the new `IntoPyObject` trait (which is fallible). To ease migration, this PR only disables deprecation warnings as errors in the affected files. (Unfortunately, `IntoPyObject` was not introduced in the current v0.22.x version and so we cannot migrate ahead of the upgrade (unlike what was done in #21670 for the new `pyclass` Sync requirement).) Migration will take place in follow-on PRs. - This PR does add an implementation of `IntoPyObject` for `&Value` to support some existing call sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of upgrading to PyO3 v0.23.x, access to
pyclass-annotated types will no longer be implicitly synchronized against the Python GIL. Thosepyclass-annotated types must now beSyncand provide that synchronization explicitly.Several places in Pants use
RefCellwhich is not Send/Sync by itself. This PR usespyo3::sync::GILProtectedto provide explicit synchronization against the GIL for those use cases. (Eventually, we may wish to not useGILProtectedto enable use of the Python 3.13 "no GIL" free threaded build, but that day is not today.)Migration guide