generalize glob syntax for known third party docker images #21711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pantsbuild#21076 a subsystem was introduced to provide better warnings for images that are "not found". It includes a method to either listing out known images, or using `*` as a wildcard to assume "everything else" that doesn't look like a target is an image. This diff, generalized the `*` syntax to allow expressing something like `my.internal.registry.io/*` is the (only) source of non-target images. ref pantsbuild#18346
lilatomic
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #21076 a subsystem was introduced to provide better warnings for images that are "not found". It includes a method to either listing out known images, or using
*as a wildcard to assume "everything else" that doesn't look like a target is an image. This diff, generalized the*syntax to allow expressing something likemy.internal.registry.io/*is the (only) source of non-target images.ref #18346