infer the PBS release tag from the user-supplied URLs #21739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR stacks on top of #21710 which will need to land first. |
Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
…one/constraints.py Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
|
The base PR #21710 landed today so this PR should be much easier to review now. |
cburroughs
approved these changes
Dec 16, 2024
tdyas
added a commit
that referenced
this pull request
Dec 26, 2024
Infer most PBS-related metadata from the artifact download URL provided by the user. (The SHA256 checksum and file size are not inferred from the URL.) Adds a three field format for `--python-build-standalone-known-python-versions` which infers all PBS-related metadata from the URL. Format is `SHA256|FILE_SIZE|URL`. The five field format is still supported. Remove the `--python-build-standalone-require-inferrable-release-tag` option added by #21739 because the PBS release tag can now be optionally provided in the version field (first field) of the five field format for `--python-build-standalone-known-python-versions`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infer the PBS "release tag" for PBS releases supplied via the
--python-build-standalone-known-python-versionsoption from the given URLs if those URLs conform to the naming convention used by the PBS project.The new advanced option
--python-build-standalone-require-inferrable-release-tagcontrols whether Pants requires the tag to be inferrable. This option currently defaults toFalse, but will be migrated toTruein a future Pants release.Note: This PR does not implement explicitly providing the release tag via
--python-build-standalone-known-python-versionssince changing how the|-separated values are parsed would need to be done in a backwards-compatible manner. That is something we may want to explore in a future PR but this PR does not go there.