Fixes the bug where pants doesn't recognize build targets on top-level d... #218
Conversation
| return os.sep in spec or ':' in spec | ||
| if os.sep in spec or ':' in spec: | ||
| return True # Definitely not a goal. | ||
| if Phase(spec).goals(): |
There was a problem hiding this comment.
The help says:
./pants goal [option ...] [goal ...] [target...] Attempt the specified goals.
This implies that once you get a target, there can be no more goals. I don't see this reflected in the existing logic.
I'm thinking that the shorthand usage is not correct. Maybe something more like this correctly expresses it:
./pants goal [option ...] [ goal [target ...] ] [ goal [target ...]] ...
There was a problem hiding this comment.
OK, I see down lower ( elif '--' == arg: ) that there is mention of intermixing targets and goals. so it looks like this is supposed to be legal?
pants goal binary foo compile bar server
pants goal
I wonder if we can get some background on this because this parsing looks pretty fragile trying to handle all these cases.
For example, the code for enforcing that specs appear on the right doesn't enforce that goals appear only on the left. This is important because if we have a one directory deep BUILD file that conflicts with any goal name, it will always be considered a goal, so we need a testcase like:
binary/BUILD # contains a definition named 'binary' for a default target.
pants goal binary -- binary
In this case, would we want
pants goal binary binary
to work? It isn't ambiguous when you think about it (binary must have a spec following)
There was a problem hiding this comment.
OK, it does look like pants goal binary -- binary would work - there is a break out of the 'enumerate(args):' loop and every non dashed argument is added to specs.
|
Looks good, please rebase and post to RBCommons for pants-devel to review. |
…l directories. The previous argument parser naively simply checked whether a command-line argument contained a slash (/) or a colon (:). This is a reasonable assumption most of the time, but in the case where a BUILD file is located only one directory deep, (eg, buildroot/folder/BUILD), this makes it impossible to run pants on the target simply by calling (eg) ./pants goal bundle folder. See github issue for example: pantsbuild#159 This fixes it by actually checking to see if a phase with goals is defined by the command-line argument. It still checks before that whether the argument contains a slash or a colon, because that if an argument has those characters it can't mean a goal. But an argument not having those characters doesn't mean it is a goal. In a completely ambiguous situation (eg, given a command argument 'bundle', and there is a valid BUILD file at bundle/BUILD), we err on the side of the goal, and print out a warning. This makes sense, because it allows the user to disambiguate the situation using the '--' syntax.
...irectories.
The previous argument parser naively simply checked whether a command-line argument contained a slash (/) or a colon (:). This is a reasonable assumption most of the time, but in the case where a BUILD file is located only one directory deep, (eg, buildroot/folder/BUILD), this makes it impossible to run pants on the target simply by calling (eg) ./pants goal bundle folder.
See github issue for example: #159
This fixes it by actually checking to see if a phase with goals is defined by the command-line argument, and whether a BUILD file associated with the spec actually exists. It still checks before that whether the argument contains a slash or a colon, because that if an argument has those characters it can't mean a goal. But an argument not having those characters doesn't mean it is a goal.