Leverage default targets throughout pants BUILDs. #3936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the default name protocol to managed_jar_dependencies to support this cleanup sweep.
jsirois
force-pushed
the
jsirois/BUILD/default_name
branch
from
f96fbeb
to
5b93ccf
Compare
|
Submitted @ cace0c4 |
stuhood
pushed a commit
that referenced
this pull request
Oct 18, 2016
Adds scalafmt formatting to the fmt command for scala files. Refactored ScalaFmt class into a base class, with two sub classes ScalaFmtCheckFormat (checks if files are formatted correctly) and ScalaFmtFormat (formats the files). This ensures that the same version of scalafmt is used for both. Both of these are currently turned off in pants.ini. Skip=True Testing Done: New Integration Test Case CI passes [#3936](#3963) Reviewed at https://rbcommons.com/s/twitter/r/4312/
stuhood
pushed a commit
that referenced
this pull request
Oct 18, 2016
Adds scalafmt formatting to the fmt command for scala files. Refactored ScalaFmt class into a base class, with two sub classes ScalaFmtCheckFormat (checks if files are formatted correctly) and ScalaFmtFormat (formats the files). This ensures that the same version of scalafmt is used for both. Both of these are currently turned off in pants.ini. Skip=True Testing Done: New Integration Test Case CI passes [#3936](#3963) Reviewed at https://rbcommons.com/s/twitter/r/4312/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the default name protocol to managed_jar_dependencies to
support this cleanup sweep.
https://rbcommons.com/s/twitter/r/4287/