Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python distribution task for user-defined setup.py + integration with ./pants {run/binary/test} #5141

Merged
merged 91 commits into from
Feb 7, 2018
Merged

Python distribution task for user-defined setup.py + integration with ./pants {run/binary/test} #5141

merged 91 commits into from
Feb 7, 2018

Commits on Jan 30, 2018

  1. Python_distribution example

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    3ec11c2 View commit details
    Browse the repository at this point in the history

  2. First pass at distribution task and target

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    ca86bf6 View commit details
    Browse the repository at this point in the history

  3. Working package example for hello2

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    46eab74 View commit details
    Browse the repository at this point in the history

  4. Changes to hello2 package

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    3aa0fe4 View commit details
    Browse the repository at this point in the history

  5. Changes to python binary creation + add new target definition

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    cd32058 View commit details
    Browse the repository at this point in the history

  6. Working python dist example

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    4f9bc98 View commit details
    Browse the repository at this point in the history

  7. Modify example to use superhello

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    5837f30 View commit details
    Browse the repository at this point in the history

  8. Working superhello project equivalent to backends/tensorflow

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    dd99194 View commit details
    Browse the repository at this point in the history

  9. Minor cleanup

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    4e2b1b9 View commit details
    Browse the repository at this point in the history

  10. Finalized initial approach at packaging wheels w/ c sources into a pex

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    74bfb8c View commit details
    Browse the repository at this point in the history

  11. Add tensorflow dependency example to superhello; this puts ./pants bi… 

    …nary on main:main in a good state for a workable demo
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    83be228 View commit details
    Browse the repository at this point in the history

  12. Add cleanup of egg-info in pex build util

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    c8a954e View commit details
    Browse the repository at this point in the history

  13. Clean up + add some docs

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    9cd32a4 View commit details
    Browse the repository at this point in the history

  14. Clean up misc style issues and delete unnecessary file.

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    1940c53 View commit details
    Browse the repository at this point in the history

  15. Remove excess __init__.py files

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    0ae435e View commit details
    Browse the repository at this point in the history

  16. First stab at run task

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    6585142 View commit details
    Browse the repository at this point in the history

  17. pants run task implementation - first pass

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    194452b View commit details
    Browse the repository at this point in the history

  18. Add python_distribution to backend/targets build file

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    e2f84cc View commit details
    Browse the repository at this point in the history

  19. First pass at kwlzn change suggestions

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    7297096 View commit details
    Browse the repository at this point in the history

  20. PythonDistribution -> inherit Target instead of PythonTarget

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    9bb228f View commit details
    Browse the repository at this point in the history

  21. Create python distribution task and refactor example

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    c340abf View commit details
    Browse the repository at this point in the history

  22. Debug session 1

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    4b65461 View commit details
    Browse the repository at this point in the history

  23. Install Python Dist create task

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    e4c0556 View commit details
    Browse the repository at this point in the history

  24. Progress on pex_build_util

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    7823d2a View commit details
    Browse the repository at this point in the history

  25. Working distribution creation task

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    76aeda2 View commit details
    Browse the repository at this point in the history

  26. Further iteration on python distribution task, now functioning for py… 

    …thon binary create
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    4b64f2d View commit details
    Browse the repository at this point in the history

  27. Minor cleanup + rename alias to be standard

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    b6fa385 View commit details
    Browse the repository at this point in the history

  28. More cleanup of docs

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    8436dad View commit details
    Browse the repository at this point in the history

  29. Run/test

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    1c981f7 View commit details
    Browse the repository at this point in the history

  30. Revert pants run mods and fix bug in pex build util

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    6881a72 View commit details
    Browse the repository at this point in the history

  31. Remove cruft

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    a859f46 View commit details
    Browse the repository at this point in the history

  32. pants test example

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    314ecfb View commit details
    Browse the repository at this point in the history

  33. Working distribution create task and integration for pants run/binary… 

    …/test
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    23f6999 View commit details
    Browse the repository at this point in the history

  34. Fix minor BUILD file error to pass CI

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    fb1c903 View commit details
    Browse the repository at this point in the history

  35. Add guard statement for case where pants test run does not require da… 

    …ta from PythonCreateDistributions task.
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    59ff560 View commit details
    Browse the repository at this point in the history

  36. Remove unused imports and add guard from consuming python dist products

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    51e9c64 View commit details
    Browse the repository at this point in the history

  37. Remove unused imports created from refactor

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    7b8e8be View commit details
    Browse the repository at this point in the history

  38. Whitespace lint fixes and unused import

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    177c379 View commit details
    Browse the repository at this point in the history

  39. Another whitespace error

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    31d3a91 View commit details
    Browse the repository at this point in the history

  40. Easy nits and whitespace issues

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    8c7b658 View commit details
    Browse the repository at this point in the history

  41. More cleanup + move stuff in task execution under invalidated

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    edf110d View commit details
    Browse the repository at this point in the history

  42. Working caching under vt.results dir. Moving to tests.

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    dacd672 View commit details
    Browse the repository at this point in the history

  43. Solid working state based off of vt.results dir caching

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    53a1355 View commit details
    Browse the repository at this point in the history

  44. Working goals using invalidated blocks

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    401a10d View commit details
    Browse the repository at this point in the history

  45. Add integration testing and simple unit test for python create distri… 

    …butions task. Also cleanup code to DRY by creating util helper method and streamline invalid python dist target detection.
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    056e267 View commit details
    Browse the repository at this point in the history

  46. Add detection of multiple setup.py files and throw an error.

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    5f4e07c View commit details
    Browse the repository at this point in the history

  47. Style fixes and cruftslaying per rjiang's comments

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    365e708 View commit details
    Browse the repository at this point in the history

  48. Fix merge conflict

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    3e1739f View commit details
    Browse the repository at this point in the history

  49. Clean up comments, docstrings, and fix broken testprojects integratio… 

    …n tests
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    e2bf445 View commit details
    Browse the repository at this point in the history

  50. Add rjiang suggestion for counting setup.py files

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    022b1e7 View commit details
    Browse the repository at this point in the history

  51. Addresses a few changes

    Lionel Vital authored and Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    be2583a View commit details
    Browse the repository at this point in the history

  52. Fix install directory clobbering and setup.py positioning

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    f1ed6da View commit details
    Browse the repository at this point in the history

  53. Fix install directory clobbering and setup.py positioning

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    4e9bb6b View commit details
    Browse the repository at this point in the history

  54. Remove unneccessary checks for invalid targets and streamline method … 

    …signatures
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    03bc4c0 View commit details
    Browse the repository at this point in the history

  55. Remove cruft

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    a2116c4 View commit details
    Browse the repository at this point in the history

  56. Add TODO with github link for package conflict case in python dist ba… 

    …ckend
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    9e0b2d6 View commit details
    Browse the repository at this point in the history

  57. Fix multiple binary target case and add integration test

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    e8f6b98 View commit details
    Browse the repository at this point in the history

  58. Cleanup integration test and move superhello test project to examples… 

    …/tests due to test breakage when placed in testprojects
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    4fd1567 View commit details
    Browse the repository at this point in the history

  59. Remove unnecessary targets from BUILD file in superhello_testproject

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    d41e7ee View commit details
    Browse the repository at this point in the history

  60. Remove tests that break testprojects integration testing

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    a6377e4 View commit details
    Browse the repository at this point in the history

  61. Update TODO github issue link

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    aabf88f View commit details
    Browse the repository at this point in the history

  62. Simplify a few lines, add check for ambiguous python dists, and fix c… 

    …opyright date
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    fe8dd55 View commit details
    Browse the repository at this point in the history

  63. Edge case impl for same setup.py package name/version as a binary dep

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    2925530 View commit details
    Browse the repository at this point in the history

  64. remove unneeded dependency test

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    c6edc08 View commit details
    Browse the repository at this point in the history

  65. Remove crufty files

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    ffae43d View commit details
    Browse the repository at this point in the history

  66. Add integration tests for targets that conflict with transitive deps … 

    …listed in the install_requires field of a python distribution's setup.py
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    cae065c View commit details
    Browse the repository at this point in the history

  67. Fix issues with CI and failing testprojects target

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    178bcbd View commit details
    Browse the repository at this point in the history

  68. Remove duplicate functions to enforce DRY

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    a4150d0 View commit details
    Browse the repository at this point in the history

  69. Remove add_labels from PythonDistribution object

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    22b72f0 View commit details
    Browse the repository at this point in the history

  70. Remove unused import

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    654c20e View commit details
    Browse the repository at this point in the history

  71. Fix lint

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    eb8598d View commit details
    Browse the repository at this point in the history

  72. Add xfail test to testprojects tests

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    3024a34 View commit details
    Browse the repository at this point in the history

  73. Disallow dependencies on a python_dist target

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    7f757c0 View commit details
    Browse the repository at this point in the history

  74. Resolve merge conflicts from removal of tasks2

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    0b82067 View commit details
    Browse the repository at this point in the history

  75. Slightly modify test assertion for conflicting deps test

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    a787717 View commit details
    Browse the repository at this point in the history

  76. Add clean-all statements to integration tests to gauge flakiness

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    8ac832b View commit details
    Browse the repository at this point in the history

  77. Add remove command to travis.yml to remove problematic file from fail… 

    …ing CI target
    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    59164c1 View commit details
    Browse the repository at this point in the history

  78. Rename superhello to fasthello

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    b4d367c View commit details
    Browse the repository at this point in the history

  79. Rebase with master

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    1a04e80 View commit details
    Browse the repository at this point in the history

  80. Remove mod to travis yml

    Chris Livingston committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    9e3d2ca View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Simplify guard clause for built dists

    Chris Livingston committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    d6dca9c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2018

  1. Formatting changes

    Chris Livingston committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    f5d3a52 View commit details
    Browse the repository at this point in the history

  2. Add PythonDistribution.alias to register

    Chris Livingston committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    46bd7c0 View commit details
    Browse the repository at this point in the history

  3. Remove redundant py_dist adding and simplify req lib injection

    Chris Livingston committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    c231963 View commit details
    Browse the repository at this point in the history

  4. Use cache keys for addressing synthetic targets

    Chris Livingston committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    8c6a4b9 View commit details
    Browse the repository at this point in the history

  5. Change resolve requirements call site and signature

    Chris Livingston committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    445cb98 View commit details
    Browse the repository at this point in the history

  6. Add support and test case for binary task python dist isolation

    Chris Livingston committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    1dc8724 View commit details
    Browse the repository at this point in the history

  7. Fix CI failures

    Chris Livingston committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    de1939b View commit details
    Browse the repository at this point in the history

  8. Fix lint error

    Chris Livingston committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    f65978e View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. Refactor synthetic req injection method

    Chris Livingston committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    bf2b553 View commit details
    Browse the repository at this point in the history

  2. Synthetic address modifications

    Chris Livingston committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    4b2fae5 View commit details
    Browse the repository at this point in the history