Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't special-case python dists in resolve_requirements(). #5483

Merged
merged 3 commits into from
Feb 20, 2018

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Feb 20, 2018

Since we now synthesize PythonRequirementLibrary targets for
each local dist, there's no need to handle them specially.

Also, ensure we create the required product even on an empty
set of requirements, so downstream code doesn't have to
check for this case.

Since we now synthesize PythonRequirementLibrary targets for
each local dist, there's no need to handle them specially.
"""Requirements resolution for PEX files.

:param req_libs: A list of :class:`PythonRequirementLibrary` targets to resolve.
:param local_dist_targets: A list of :class:`PythonDistribution` targets to resolve.
:returns: a PEX containing target requirements and any specified python dist targets.
"""
tgts = req_libs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could kill this local var and use req_libs directly in self.invalidated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Of course. Good eye. Fixed.

Copy link
Contributor

@CMLivingston CMLivingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! Just one suggestion.

@benjyw benjyw merged commit 71a33d6 into pantsbuild:master Feb 20, 2018
@benjyw benjyw deleted the remove_dist_cruft branch February 20, 2018 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants