Don't special-case python dists in resolve_requirements(). #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now synthesize PythonRequirementLibrary targets for each local dist, there's no need to handle them specially.
| """Requirements resolution for PEX files. | ||
|
|
||
| :param req_libs: A list of :class:`PythonRequirementLibrary` targets to resolve. | ||
| :param local_dist_targets: A list of :class:`PythonDistribution` targets to resolve. | ||
| :returns: a PEX containing target requirements and any specified python dist targets. | ||
| """ | ||
| tgts = req_libs |
There was a problem hiding this comment.
I think we could kill this local var and use req_libs directly in self.invalidated.
There was a problem hiding this comment.
D'oh! Of course. Good eye. Fixed.
CMLivingston
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now synthesize PythonRequirementLibrary targets for
each local dist, there's no need to handle them specially.
Also, ensure we create the required product even on an empty
set of requirements, so downstream code doesn't have to
check for this case.