Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SelectProjection #5672

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Remove SelectProjection #5672

merged 1 commit into from
Apr 6, 2018

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Apr 6, 2018

SelectProjection is entirely superseded by the new @rule coroutine syntax from #5580.

kwlzn
kwlzn approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stuhood stuhood merged commit 79d9d35 into pantsbuild:master Apr 6, 2018
@stuhood stuhood deleted the stuhood/remove-select-projection branch April 6, 2018 18:57
@baroquebobcat
Copy link
Contributor

Nice!

@stuhood stuhood mentioned this pull request Apr 9, 2018
Merged
@kwlzn kwlzn mentioned this pull request May 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwlzn kwlzn kwlzn approved these changes

@baroquebobcat baroquebobcat Awaiting requested review from baroquebobcat

@illicitonion illicitonion Awaiting requested review from illicitonion

@ity ity Awaiting requested review from ity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuhood @baroquebobcat @kwlzn