Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support output directory saving in remote execution #6167

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Support output directory saving in remote execution #6167

merged 1 commit into from
Jul 18, 2018

Conversation

illicitonion
Copy link
Contributor

Fixes #5995

stuhood
stuhood approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/rust/engine/process_execution/src/remote.rs
.to_owned();
for dir in output_directories {
let digest_result: Result<Digest, String> = dir.get_tree_digest().into();
let mut digest = future::done(digest_result).to_boxed();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah. That's a first.

@illicitonion illicitonion merged commit aceff3e into pantsbuild:master Jul 18, 2018
@illicitonion illicitonion deleted the dwagnerhall/remoteex/outputdirs branch July 18, 2018 08:51
@baroquebobcat
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@baroquebobcat baroquebobcat Awaiting requested review from baroquebobcat

@dotordogh dotordogh Awaiting requested review from dotordogh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illicitonion @baroquebobcat @stuhood