Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the 1.9.0rc0 release. #6171

Merged
merged 12 commits into from
Jul 19, 2018

Conversation

cosmicexplorer
Copy link
Contributor

@cosmicexplorer cosmicexplorer commented Jul 18, 2018

Followed "Release Process" and "Release Strategy" pages on pantsbuild.org, and ensured the changes were exactly the same as the 1.8.0rc0 release PR. Let me know if there are any other sources I should take a look at / if I've done something horribly wrong.

EDIT: Also let me know if these are the right reviewers to add for this PR.

Copy link
Contributor

@jsirois jsirois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rst notes also apply to https://github.com/pantsbuild/pants/pull/6171/files#diff-643a09ef8bf6ce95a5e5eac18bfc08c3

I think you missed running ./build-support/bin/contributors.sh - that should pick up an edit to CONTRIBUTORS.md adding Wilhelmina Drengwitz

`PR #6095 <https://github.com/pantsbuild/pants/pull/6095>`_

Python 3 porting (#6062)
------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a ~* heading instead of -*.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -- I was thinking that this would make sense as a subheading of the "Refactoring, Improvements, and Tooling" section. But looking through other notes now I don't see any other examples of this, so I will change it to a ~* heading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4800643!


This document describes releases leading up to the ``1.9.x`` ``stable`` series.

1.9.0rc0 (07/17/2018)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a bump to today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 9a717b6!

Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on the issues that John pointed out. Otherwise, looks good.

@cosmicexplorer
Copy link
Contributor Author

I realized that I had set my name as "Daniel McClanahan" on this laptop's ~/.gitconfig after running build-support/bin/contributors.sh, so fixed that in the meantime as well.

@cosmicexplorer
Copy link
Contributor Author

To clarify, build-support/bin/contributors.sh is very clearly specified on the release process page, so that was purely my mistake -- but looking to make other release doc improvements after a bit more work on doing the release.

@cosmicexplorer
Copy link
Contributor Author

Made a comment here earlier that I deleted — I have included the commit message from #6181, and will merge this when ci goes green, and do the pypi release tomorrow morning in California time.

@cosmicexplorer cosmicexplorer merged commit 3afceb9 into pantsbuild:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants