Prepare the 1.9.0rc0 release. #6171
Conversation
cosmicexplorer
requested review from
stuhood,
baroquebobcat,
jsirois,
benjyw,
wisechengyi and
kwlzn
There was a problem hiding this comment.
The rst notes also apply to https://github.com/pantsbuild/pants/pull/6171/files#diff-643a09ef8bf6ce95a5e5eac18bfc08c3
I think you missed running ./build-support/bin/contributors.sh - that should pick up an edit to CONTRIBUTORS.md adding Wilhelmina Drengwitz
src/python/pants/notes/1.9.x.rst
Outdated
| `PR #6095 <https://github.com/pantsbuild/pants/pull/6095>`_ | ||
|
|
||
| Python 3 porting (#6062) | ||
| ------------------------ |
There was a problem hiding this comment.
This should be a ~* heading instead of -*.
There was a problem hiding this comment.
Yes -- I was thinking that this would make sense as a subheading of the "Refactoring, Improvements, and Tooling" section. But looking through other notes now I don't see any other examples of this, so I will change it to a ~* heading.
There was a problem hiding this comment.
Done in 4800643!
src/python/pants/notes/1.9.x.rst
Outdated
|
|
||
| This document describes releases leading up to the ``1.9.x`` ``stable`` series. | ||
|
|
||
| 1.9.0rc0 (07/17/2018) |
There was a problem hiding this comment.
This will need a bump to today.
There was a problem hiding this comment.
Done in 9a717b6!
|
I realized that I had set my name as "Daniel McClanahan" on this laptop's |
|
To clarify, |
cosmicexplorer
force-pushed
the
prepare-1.9.0rc0
branch
from
9a717b6
to
b7ec67c
Compare
This reverts commit d031577.
cosmicexplorer
force-pushed
the
prepare-1.9.0rc0
branch
from
b7ec67c
to
9afaf49
Compare
|
Made a comment here earlier that I deleted — I have included the commit message from #6181, and will merge this when ci goes green, and do the pypi release tomorrow morning in California time. |
Followed "Release Process" and "Release Strategy" pages on pantsbuild.org, and ensured the changes were exactly the same as the 1.8.0rc0 release PR. Let me know if there are any other sources I should take a look at / if I've done something horribly wrong.
EDIT: Also let me know if these are the right reviewers to add for this PR.