Port pants-plugins #6209
Merged
Port pants-plugins #6209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisechengyi
reviewed
Jul 20, 2018
| @@ -234,7 +234,7 @@ def ensure_page_headings_linkable(soup): | |||
|
|
|||
| def link_pantsrefs(soups, precomputed): | |||
| """Transorm soups: <a pantsref="foo"> becomes <a href="../foo_page.html#foo">""" | |||
| for (page, soup) in soups.items(): | |||
| for (page, soup) in list(soups.items()): | |||
There was a problem hiding this comment.
should still work without changes, right?
$ python3
Python 3.6.1 (v3.6.1:69c0db5050, Mar 21 2017, 01:21:04)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> {1:2,3:4}.items()
dict_items([(1, 2), (3, 4)])
There was a problem hiding this comment.
It should! I missed this and will fix when I get a chance.
The futurize script is extra conservative because sometimes you do need to wrap in a list, eg when accessing a specific index. Here, the view is preferred and far more performant.
Thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6062