Port examples #6210
Merged
Port examples #6210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
commented
Jul 20, 2018
| @@ -8,8 +8,8 @@ | |||
| from distutils.core import Extension | |||
|
|
|||
|
|
|||
| c_module = Extension(str('c_greet'), sources=[str('c_greet.c')]) | |||
| cpp_module = Extension(str('cpp_greet'), sources=[str('cpp_greet.cpp')]) | |||
| c_module = Extension(b'c_greet', sources=[b'c_greet.c']) | |||
There was a problem hiding this comment.
I'm assuming the call to str() around string literals was to convert into byte strings, because from __future__ import unicode_literals is toggled on? If not, and unicode works, we can remove both b prefix and str().
| @@ -14,7 +14,7 @@ | |||
| # This is for testing purposes so we can assert that setup_requires is functioning | |||
| # correctly (because Pants swallows print statements). | |||
| if os.getenv('PANTS_TEST_SETUP_REQUIRES', ''): | |||
| output = [str(pycountry)] | |||
| output = [bytes(pycountry)] | |||
There was a problem hiding this comment.
Assuming similar logic here that you want bytes instead of unicode?
If you want unicode, I don't know of a Py2 Py3 compatible way of specifying we want unicode because we can't import six or future. unicode() is only supported in Py2.
stuhood
approved these changes
Jul 20, 2018
CMLivingston
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6062
This folder was unlike any we've worked with. Because it's a dist, you aren't allowed to include
futureas a 3rd party library. So we unfortunately can't use the backports.I also couldn't find tests for the particular folder
cc @CMLivingston if you could help review please.