remove env modifications from the setup.py invocation environment #6329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Aug 9, 2018
stuhood
approved these changes
Aug 9, 2018
cosmicexplorer
force-pushed
the
remove-setup-py-env-mods
branch
from
329a0df
to
8a89c87
Compare
|
Upon further review, this PR is not currently necessary. The correct and within grasp solution (it seems) is to instead focus on #6273 so that we have deeper control of our compiler and linker command lines when compiling native code, instead of just relying on distutils to do the right thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of changes made to
setup_py.pyin #5943 because internal testing at Twitter has shown this is buggy. There are currently no consumers or tests for this behavior -- we will add tests when we have a fix.