Run clippy with nightly rust on CI

src/rust/engine/async_semaphore/src/lib.rs

@@ -1,3 +1,20 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 extern crate futures;
 
 use std::collections::VecDeque;

src/rust/engine/boxfuture/src/lib.rs

@@ -2,6 +2,23 @@
 // https://github.com/alexcrichton/futures-rs/issues/228 has background for its removal.
 // This avoids needing to call Box::new() around every future that we produce.
 
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 extern crate futures;
 
 use futures::future::Future;

src/rust/engine/build_utils/src/lib.rs

@@ -1,3 +1,20 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 use std::env;
 use std::io;
 use std::ops::Deref;

src/rust/engine/fs/brfs/src/main.rs

@@ -1,3 +1,20 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 extern crate bazel_protos;
 extern crate clap;
 extern crate dirs;

src/rust/engine/fs/fs_util/src/main.rs

@@ -1,3 +1,20 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 #[macro_use]
 extern crate boxfuture;
 extern crate bytes;

src/rust/engine/fs/src/lib.rs

@@ -1,6 +1,23 @@
 // Copyright 2017 Pants project contributors (see CONTRIBUTORS.md).
 // Licensed under the Apache License, Version 2.0 (see LICENSE).
 
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 mod glob_matching;
 pub use glob_matching::GlobMatching;
 mod snapshot;

src/rust/engine/graph/src/entry.rs

@@ -50,6 +50,7 @@ impl Generation {
   }
 }
 
+#[cfg_attr(feature = "cargo-clippy", allow(type_complexity))]
 pub(crate) enum EntryState<N: Node> {
   // A node that has either been explicitly cleared, or has not yet started Running. In this state
   // there is no need for a dirty bit because the RunToken is either in its initial state, or has

src/rust/engine/graph/src/lib.rs

@@ -1,6 +1,23 @@
 // Copyright 2018 Pants project contributors (see CONTRIBUTORS.md).
 // Licensed under the Apache License, Version 2.0 (see LICENSE).
 
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 extern crate boxfuture;
 extern crate fnv;
 extern crate futures;

src/rust/engine/hashing/src/lib.rs

@@ -1,6 +1,23 @@
 // Copyright 2017 Pants project contributors (see CONTRIBUTORS.md).
 // Licensed under the Apache License, Version 2.0 (see LICENSE).
 
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 extern crate digest;
 extern crate hex;
 extern crate sha2;

src/rust/engine/process_execution/src/lib.rs

@@ -1,3 +1,20 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 extern crate async_semaphore;
 extern crate bazel_protos;
 #[macro_use]

src/rust/engine/process_executor/src/main.rs

@@ -1,3 +1,18 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 #[macro_use]
 extern crate clap;
 extern crate env_logger;

src/rust/engine/resettable/src/lib.rs

@@ -1,3 +1,20 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 use std::sync::{Arc, RwLock};
 
 ///

src/rust/engine/src/context.rs

@@ -43,6 +43,7 @@ pub struct Core {
 }
 
 impl Core {
+  #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]
   pub fn new(
     root_subject_types: Vec<TypeId>,
     tasks: Tasks,

src/rust/engine/src/lib.rs

@@ -1,6 +1,27 @@
 // Copyright 2017 Pants project contributors (see CONTRIBUTORS.md).
 // Licensed under the Apache License, Version 2.0 (see LICENSE).
 
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+// We only use unsafe pointer derefrences in our no_mangle exposed API, but it is nicer to list
+// just the one minor call as unsafe, than to mark the whole function as unsafe which may hide
+// other unsafeness.
+#![cfg_attr(feature = "cargo-clippy", allow(not_unsafe_ptr_arg_deref))]
+
 pub mod cffi_externs;
 mod context;
 mod core;

src/rust/engine/testutil/mock/src/lib.rs

@@ -1,3 +1,22 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+// We use a bunch of complex compound tuples for storing call arguments.
+#![cfg_attr(feature = "cargo-clippy", allow(type_complexity))]
+
 extern crate bazel_protos;
 extern crate bytes;
 extern crate futures;

src/rust/engine/testutil/src/lib.rs

@@ -1,3 +1,20 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 extern crate bazel_protos;
 extern crate bytes;
 extern crate digest;

src/rust/engine/ui/src/display.rs

@@ -1,3 +1,20 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 extern crate rand;
 extern crate termion;
 extern crate unicode_segmentation;

src/rust/engine/ui/src/main.rs

@@ -1,3 +1,20 @@
+// Enable all clippy lints except for many of the pedantic ones. It's a shame this needs to be copied and pasted across crates, but there doesn't appear to be a way to include inner attributes from a common source.
+#![cfg_attr(
+  feature = "cargo-clippy",
+  deny(
+    clippy, default_trait_access, expl_impl_clone_on_copy, if_not_else, needless_continue,
+    single_match_else, unseparated_literal_suffix, used_underscore_binding
+  )
+)]
+// It is often more clear to show that nothing is being moved.
+#![cfg_attr(feature = "cargo-clippy", allow(match_ref_pats))]
+// Subjective style.
+#![cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty, redundant_field_names))]
+// Default isn't as big a deal as people seem to think it is.
+#![cfg_attr(feature = "cargo-clippy", allow(new_without_default, new_without_default_derive))]
+// Arc<Mutex> can be more clear than needing to grok Orderings:
+#![cfg_attr(feature = "cargo-clippy", allow(mutex_atomic))]
+
 extern crate engine_display;
 extern crate rand;