Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python test runner uses pytest #6661

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

illicitonion
Copy link
Contributor

No description provided.

@illicitonion
Copy link
Contributor Author

Only the top commit is new; dependencies are #6660 and #6646

dirs = tuple(sorted(dirs))

# Note that this hasn't been published yet, but needs https://github.com/pantsbuild/pex/pull/605 to be released
pex_snapshot = yield Get(Snapshot, UrlToFetch, UrlToFetch("https://github.com/pantsbuild/pex/releases/download/v1.5.2/pex27"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: URL should be parameterised

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John was kind enough to publish v1.5.2 this past weekend.

@stuhood
Copy link
Member

stuhood commented Nov 8, 2018

Rebased and added one commit on top to account for the changes in #6660.

@illicitonion illicitonion force-pushed the dwagnerhall/v2/python branch 3 times, most recently from ddd9ec1 to b119263 Compare November 8, 2018 17:45
@baroquebobcat
Copy link
Contributor

This looks really slick for a first pass.

@illicitonion
Copy link
Contributor Author

Rebased, travis is green, PTAL @stuhood @baroquebobcat :)

Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stuhood stuhood merged commit da31a1d into pantsbuild:master Nov 14, 2018
@stuhood stuhood deleted the dwagnerhall/v2/python branch November 14, 2018 00:52
@stuhood stuhood mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants