Python test runner uses pytest #6661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
dwagnerhall/v2/python
branch
from
f6122ce
to
f6323f7
Compare
illicitonion
commented
Oct 19, 2018
| dirs = tuple(sorted(dirs)) | ||
|
|
||
| # Note that this hasn't been published yet, but needs https://github.com/pantsbuild/pex/pull/605 to be released | ||
| pex_snapshot = yield Get(Snapshot, UrlToFetch, UrlToFetch("https://github.com/pantsbuild/pex/releases/download/v1.5.2/pex27")) |
There was a problem hiding this comment.
TODO: URL should be parameterised
There was a problem hiding this comment.
John was kind enough to publish v1.5.2 this past weekend.
stuhood
force-pushed
the
dwagnerhall/v2/python
branch
from
f6323f7
to
e85b5bb
Compare
|
Rebased and added one commit on top to account for the changes in #6660. |
illicitonion
force-pushed
the
dwagnerhall/v2/python
branch
3 times, most recently
from
ddd9ec1
to
b119263
Compare
|
This looks really slick for a first pass. |
illicitonion
force-pushed
the
dwagnerhall/v2/python
branch
from
b119263
to
87fcf05
Compare
|
Rebased, travis is green, PTAL @stuhood @baroquebobcat :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.