Header file extensions as options for C/C++ targets #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
reviewed
Nov 26, 2018
src/python/pants/backend/native/subsystems/native_build_step_settings.py
Outdated
Show resolved
Hide resolved
CMLivingston
approved these changes
Nov 26, 2018
To clarify, this is because pants will currently raise an error when there are header-only libraries -- this PR fixes that. |
jsirois
reviewed
Nov 27, 2018
|
|
||
| object_files_product = context.products.get(ObjectFiles) | ||
| object_files_for_target = self._retrieve_single_product_at_target_base(object_files_product, c) | ||
| # Test that no object files were produced. |
There was a problem hiding this comment.
Thanks Danny - this is a much better test!
There was a problem hiding this comment.
I think so too! I swear to you that I prevaricated for at least an hour about adding tests based on matching info logs and moved forward only to unblock myself from that particular indecision. I am planning to take your comment on the other PR #6800 and make a (concise!) followup issue to fix this in the integration tests from that PR.
cosmicexplorer
added a commit
that referenced
this pull request
Nov 28, 2018
### Problem
The file extensions we consider "header files" for C/C++ targets are hardcoded as `('.h', '.hpp')`. Additionally, we will error out on header-only `ctypes_compatible_cpp_library()` targets (as for C targets).
### Solution
- Create the `--header-file-extensions` option in the CCompileSettings and CppCompileSettings subsystems.
- Make a debug-level log if the library undergoing compile is a header-only library before early returning.
- Add some tests.
cosmicexplorer
added a commit
that referenced
this pull request
Nov 29, 2018
### Problem
The file extensions we consider "header files" for C/C++ targets are hardcoded as `('.h', '.hpp')`. Additionally, we will error out on header-only `ctypes_compatible_cpp_library()` targets (as for C targets).
### Solution
- Create the `--header-file-extensions` option in the CCompileSettings and CppCompileSettings subsystems.
- Make a debug-level log if the library undergoing compile is a header-only library before early returning.
- Add some tests.
cosmicexplorer
added a commit
that referenced
this pull request
Dec 1, 2018
### Problem
The file extensions we consider "header files" for C/C++ targets are hardcoded as `('.h', '.hpp')`. Additionally, we will error out on header-only `ctypes_compatible_cpp_library()` targets (as for C targets).
### Solution
- Create the `--header-file-extensions` option in the CCompileSettings and CppCompileSettings subsystems.
- Make a debug-level log if the library undergoing compile is a header-only library before early returning.
- Add some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The file extensions we consider "header files" for C/C++ targets are hardcoded as
('.h', '.hpp'). Additionally, we will error out on header-onlyctypes_compatible_cpp_library()targets (as for C targets).Solution
--header-file-extensionsoption in the CCompileSettings and CppCompileSettings subsystems.