Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2-UI] Move logging to Rust #6817

Merged
merged 32 commits into from
Apr 10, 2019
Merged

[V2-UI] Move logging to Rust #6817

merged 32 commits into from
Apr 10, 2019

Commits on Apr 10, 2019

  1. Move logging to rust 

    Decouple Logger::init from externs, fix missing logs

Cleanup

Transform unit tests into integration tests

Make setting max log level implicit

Remove LogExtern

Address comments and Travis failures

Close pantsd file before setting a new logger

Fix encoding in python2

Debug logging

WIP
    @illicitonion
    Borja Lorente authored and illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    4092375 View commit details
    Browse the repository at this point in the history

  2. Fix up crate config

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    b058789 View commit details
    Browse the repository at this point in the history

  3. Remove bogus logging

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    9932a29 View commit details
    Browse the repository at this point in the history

  4. Some more bogus logging

    @illicitonion
    Borja Lorente authored and illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    ddc5ef0 View commit details
    Browse the repository at this point in the history

  5. Update test expectation

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    4ff6b29 View commit details
    Browse the repository at this point in the history

  6. WIP

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    06317de View commit details
    Browse the repository at this point in the history

  7. Fix up bad rebase

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    555f3ca View commit details
    Browse the repository at this point in the history

  8. Fix tests

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    6a366c9 View commit details
    Browse the repository at this point in the history

  9. SIGUSR2 outputs to pantsd log correctly

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    7b4f5c0 View commit details
    Browse the repository at this point in the history

  10. De-dupe log format, pull out test helper

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    85d93df View commit details
    Browse the repository at this point in the history

  11. Fix rust fmt

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    f1ac593 View commit details
    Browse the repository at this point in the history

  12. Un-break test

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    56ae211 View commit details
    Browse the repository at this point in the history

  13. Remove unused variable

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    c4c8e74 View commit details
    Browse the repository at this point in the history

  14. Fix py2 which doesn't have a kwarg here

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    37631de View commit details
    Browse the repository at this point in the history

  15. Review feedback

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    2b5b3ce View commit details
    Browse the repository at this point in the history

  16. Fix lint

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    77a92f1 View commit details
    Browse the repository at this point in the history

  17. Remove print that doesn't go anywhere

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    d315f97 View commit details
    Browse the repository at this point in the history

  18. Test debugging

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    7a03b51 View commit details
    Browse the repository at this point in the history

  19. More test debugging

    @illicitonion
    Borja Lorente authored and illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    e09128e View commit details
    Browse the repository at this point in the history

  20. Run test a few times

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    796761b View commit details
    Browse the repository at this point in the history

  21. Flush logs

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    75f00b2 View commit details
    Browse the repository at this point in the history

  22. Restore travis yml

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    5cbb2f4 View commit details
    Browse the repository at this point in the history

  23. Cleanup tempdirs

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    695f169 View commit details
    Browse the repository at this point in the history

  24. Misc comments

    @illicitonion
    Borja Lorente authored and illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    bb86453 View commit details
    Browse the repository at this point in the history

  25. dup fd 

    Otherwise when python GCs the file object, it tries to close the fd, where the engine may already have closed it and re-opened another file re-using the fd
    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    118840b View commit details
    Browse the repository at this point in the history

  26. Fix test expectations

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    9d84495 View commit details
    Browse the repository at this point in the history

  27. Remove unused import

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    2a36fa0 View commit details
    Browse the repository at this point in the history

  28. Fix rustfmt

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    3daa496 View commit details
    Browse the repository at this point in the history

  29. Fix test expectations

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    258b133 View commit details
    Browse the repository at this point in the history

  30. Fix one more test

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    12bc7cf View commit details
    Browse the repository at this point in the history

  31. Address last few comments

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    8b53076 View commit details
    Browse the repository at this point in the history

  32. Fix typo

    @illicitonion
    illicitonion committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    db253a9 View commit details
    Browse the repository at this point in the history