Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reqwest uses rustls not openssl #7002

Merged
merged 2 commits into from
Jan 8, 2019

Conversation

illicitonion
Copy link
Contributor

Pure rust means easier compiling, easier linking, and fewer environmental restrictions.

Copy link
Contributor

@cosmicexplorer cosmicexplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure rust means easier compiling, easier linking, and fewer environmental restrictions.

Not when I'm done with the native code support!

I would be surprised if this change affected the failing tests -- if this isn't already that looks like we need to add a comment to #6782 or something?

@illicitonion
Copy link
Contributor Author

This PR does cause those tests to fail, for interesting reasons...

Those tests assert that nothing is logged to stderr, and with this PR, some rust logging is happening to stderr in the HTTP stack.

This opens up two interesting questions:

  1. Should those tests be asserting on stderr? Asserting that no logging happened is a fairly blunt assertion.
  2. Do we want this logging?

I think the right thing to do here is probably to tone down rust logging from 3rdparty crates, so that by default we don't log things from outside our code unless we're in trace mode. I'll do a little investigation, but may hold off on this until #6817 lands because that's a natural place from which to build more logging granularity :)

Pure rust means easier compiling, easier linking, and fewer environmental restrictions.
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

@illicitonion illicitonion merged commit 83c8003 into pantsbuild:master Jan 8, 2019
@illicitonion illicitonion deleted the dwagnerhall/reqwest/rustls branch January 8, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants