Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a TypedCollection type constraint to reduce boilerplate for datatype tuple fields #7115

Merged
merged 19 commits into from
Feb 12, 2019
Merged

add a TypedCollection type constraint to reduce boilerplate for datatype tuple fields #7115

merged 19 commits into from
Feb 12, 2019

Commits on Feb 6, 2019

  1. move Collection to src/python/pants/engine/objects.py

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    11f2c82 View commit details
    Browse the repository at this point in the history

  2. refactor TypeConstraint to allow parameterized types such as collections

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    60c376d View commit details
    Browse the repository at this point in the history

  3. do the argument checking ourselves so we can use wrapper_type

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    580054d View commit details
    Browse the repository at this point in the history

  4. add testing for TypedCollection by itself and in a datatype

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    2d79f91 View commit details
    Browse the repository at this point in the history

  5. coup de gras -- convert Collection.of() to use TypedCollection

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    5e1abe3 View commit details
    Browse the repository at this point in the history

  6. add temporary .types property

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    3ae3c64 View commit details
    Browse the repository at this point in the history

  7. clear up a docstring

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    823caca View commit details
    Browse the repository at this point in the history

  8. remove an assert and ensure wrapper_type is a type

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    979e2db View commit details
    Browse the repository at this point in the history

  9. flesh out a needed docstring

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    77685d8 View commit details
    Browse the repository at this point in the history

  10. remove an old comment

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    65e650f View commit details
    Browse the repository at this point in the history

  11. py3 compat

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    20e55c8 View commit details
    Browse the repository at this point in the history

  12. Revert "do the argument checking ourselves so we can use wrapper_type" 

    This reverts commit 5211b02.
    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    03f3c1e View commit details
    Browse the repository at this point in the history

  13. break my own heart and remove wrapper_type

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    d418372 View commit details
    Browse the repository at this point in the history

  14. respond to review comments

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    9d3a319 View commit details
    Browse the repository at this point in the history

  15. test validate_satisfied_by() and use str() in error messages

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    bff5668 View commit details
    Browse the repository at this point in the history

  16. remove uses of the previous variance symbol in testing

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    5c50f87 View commit details
    Browse the repository at this point in the history

  17. fix the last remnant of the far-too-concise __str__!

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    513cfb8 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. py3 fix, this time tested locally with ./pants3

    @cosmicexplorer
    cosmicexplorer committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    00fb59e View commit details
    Browse the repository at this point in the history

  2. fix py3 compat in the other test_objects.py

    @cosmicexplorer
    cosmicexplorer committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    2c68ba7 View commit details
    Browse the repository at this point in the history