Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to future==0.17.1 #7159

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Jan 25, 2019

Problem

future==0.16.0 cannot be resolved in the context of linux_x86_64-cp-36-cp36m (see the subtext of #7158), and it seems likely that future==0.17.1 can be, since its pypi entry claims compatibility with python 3.6. Either way, updating to the most recent version seems win-win.

Solution

Update to future==0.17.1.

@Eric-Arellano
Copy link
Contributor

You'll have to merge master to get the contrib tests to pass.

@stuhood stuhood force-pushed the stuhood/most-futuristic-future branch 2 times, most recently from ac816f0 to 2a79083 Compare January 28, 2019 18:52
@jsirois
Copy link
Contributor

jsirois commented Jan 28, 2019

You'll only get one win here. The package is an sdist - so pex will need to build it into a wheel and the sdist doesn't contain the universal flag, so it will build for 2 or 3 depending on the interpreter being used to pex things up.

@stuhood stuhood merged commit 96bd65e into pantsbuild:master Jan 29, 2019
@stuhood stuhood deleted the stuhood/most-futuristic-future branch January 29, 2019 01:29
@jsirois
Copy link
Contributor

jsirois commented Jan 30, 2019

The second win will come from a fix for pex-tool/pex#415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants