-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.14.0.dev3. #7170
Prepare 1.14.0.dev3. #7170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Stu! I appreciate you reading closely into this all and finding other related issues / PRs.
`PR #7067 <https://github.com/pantsbuild/pants/pull/7067>`_ | ||
`PR #40b3dff56ff25c0c6f336fa78f1bb6f461e79898 <https://github.com/pantsbuild/pants/pull/7067/commits/40b3dff56ff25c0c6f336fa78f1bb6f461e79898>`_ | ||
|
||
* Properly handle unicode and byte streams with pantsd for Python 3 (#7130) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to combine these two PRs into one note, which is totally acceptable as they're related, I would remove pantsd
. Maybe: Properly handle unicode and byte streams with exiter code for Python 3
#7130 was mostly finishing up the work started in #7073, with a specific focus on pantsd related code.
--
Issue #7160 is a lingering issue not resolved by these two PRs. Does it make sense to still include?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry: this is just the result of automated scraping done by build-support/bin/release-changelog-helper.sh
. I apologize for not pre-reviewing before you needed to spend the time to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah didn't realize we have a script that does that all. Neat.
No worries!
src/python/pants/notes/master.rst
Outdated
|
||
* Fixes to get contrib, lint, JVM tests, and platform-specific tests working with ./pants3 (#7067) | ||
`PR #7067 <https://github.com/pantsbuild/pants/pull/7067>`_ | ||
`PR #40b3dff56ff25c0c6f336fa78f1bb6f461e79898 <https://github.com/pantsbuild/pants/pull/7067/commits/40b3dff56ff25c0c6f336fa78f1bb6f461e79898>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to reference this specific commit, as I improved the PR description to better address it, and that commit is merely 1 of 5 changes we had to make for this PR.
It's fine if you want to keep, but I don't think necessary.
src/python/pants/notes/master.rst
Outdated
|
||
* Fix test_jvm_platform_analysis_integration.py using unknown platforms (#7140) | ||
`Issue #7139 <https://github.com/pantsbuild/pants/issues/7139>`_ | ||
`Issue #7139 <https://github.com/pantsbuild/pants/issues/7139>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate. Can delete this line.
`PR #7142 <https://github.com/pantsbuild/pants/pull/7142>`_ | ||
|
||
* Fix Idea plugin unicode issues with Python 3 (#7141) | ||
`PR #7141 <https://github.com/pantsbuild/pants/pull/7141>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we explicitly link to your earlier Bugfix entry blacklist idea plugin gen from faulty earlier edit (#7157)
? The two are closely related, in that #7157 partially reverts this PR.
src/python/pants/notes/master.rst
Outdated
|
||
* Add Python 3 support to Pytest with V2 engine (#7153) | ||
`PR #7153 <https://github.com/pantsbuild/pants/pull/7153>`_ | ||
`PR #6098 <https://github.com/pantsbuild/pants/pull/6098>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.