Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize enum pattern matching for execution strategy, platform, and elsewhere #7226

Merged
merged 11 commits into from
Feb 12, 2019
Merged

Canonicalize enum pattern matching for execution strategy, platform, and elsewhere #7226

merged 11 commits into from
Feb 12, 2019
+369 −259

Commits on Feb 12, 2019

  1. add .resolve_for_enum_variant() to enum() and refactor type checking … 

    …exceptions

- this also requires none_is_default=True to be set in .create() calls to coerce None
    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    1b40674 View commit details
    Browse the repository at this point in the history

  2. make native backend Platform into an enum

    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    0dccf3a View commit details
    Browse the repository at this point in the history

  3. make ToolchainVariant into an enum

    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    cc26f22 View commit details
    Browse the repository at this point in the history

  4. add .iterate_enum_variants() and clean up testing in test_ctypes_inte… 

    …gration.py

(this makes addressing pantsbuild#6866 later a little easier)
    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    f19ff49 View commit details
    Browse the repository at this point in the history

  5. make NailgunTask execution strategy into an enum

    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    e44ce51 View commit details
    Browse the repository at this point in the history

  6. override __new__ and clean up error messages in enum

    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    0963c3a View commit details
    Browse the repository at this point in the history

  7. add ticket links!

    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    26e89a7 View commit details
    Browse the repository at this point in the history

  8. fix outdated method name

    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    66e4f57 View commit details
    Browse the repository at this point in the history

  9. actually invoke the lazy pattern matching

    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    cb8f9d5 View commit details
    Browse the repository at this point in the history

  10. add yet another lambda invocation

    @cosmicexplorer
    cosmicexplorer committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    daa13c1 View commit details
    Browse the repository at this point in the history

  11. fix typo in src/python/pants/backend/jvm/tasks/nailgun_task.py 

    Co-Authored-By: cosmicexplorer <1305167+cosmicexplorer@users.noreply.github.com>
    @illicitonion @cosmicexplorer
    illicitonion and cosmicexplorer authored Feb 12, 2019
    Configuration menu
    Copy the full SHA
    51fd5c2 View commit details
    Browse the repository at this point in the history