When building a pex in release.sh, build it for all supported ABIs. #7393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -569,29 +569,35 @@ function build_pex() { | |||
| # If $1 == "fetch", fetches the linux and OSX wheels which were built on travis. | |||
| local mode="$1" | |||
|
|
|||
| local linux_platform="linux_x86_64" | |||
| local osx_platform="macosx_10.11_x86_64" | |||
| local linux_platform_noabi="linux_x86_64" | |||
There was a problem hiding this comment.
Nit
Suggested change
| local linux_platform_noabi="linux_x86_64" | |
| local linux_platform_no_abi="linux_x86_64" |
| local linux_platform="linux_x86_64" | ||
| local osx_platform="macosx_10.11_x86_64" | ||
| local linux_platform_noabi="linux_x86_64" | ||
| local osx_platform_noabi="macosx_10.11_x86_64" |
There was a problem hiding this comment.
Nit
Suggested change
| local osx_platform_noabi="macosx_10.11_x86_64" | |
| local osx_platform_no_abi="macosx_10.11_x86_64" |
Eric-Arellano
approved these changes
Mar 15, 2019
Merged
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 20, 2019
platform was no longer defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After #7235, we began building wheels for multiple ABIs and platforms, but when building a pex, we were allowing
pexto choose which ABI to use in the outputpex, which could result in an unusable output pex: see #7383.Solution
Explicitly include all ABIs when constructing a pex with
-p.Result
Released and nightly pexes will be larger, but much more compatible. Fixes #7383.