Remove @rule Select syntax #7477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (`Select(IntType)`), this `@rule` represents a conversion from `IntType` to `StrType`, with no | ||
| second argument is a list of parameter selectors that declare the types of the input parameters for | ||
| the `@rule`. In this case, because the Product type is `StringType` and there is one parameter | ||
| selector (for `IntType`), this `@rule` represents a conversion from `IntType` to `StrType`, with no |
There was a problem hiding this comment.
"parameter selectors" is a very good edit, this leaves the opportunity to expand it later as needed while making it extremely clear what those types are doing there.
cosmicexplorer
approved these changes
Apr 2, 2019
Eric-Arellano
approved these changes
Apr 2, 2019
illicitonion
approved these changes
Apr 2, 2019
| pub fn select_str(select: &Select) -> String { | ||
| format!("Select({})", select.product).to_string() // TODO variant key | ||
| pub fn select_root_str(select: &Select) -> String { | ||
| format!("Select({})", select.product) |
There was a problem hiding this comment.
Should we rename Select to Root or SelectRoot or something here, now that that's what it represents?
There was a problem hiding this comment.
"It's complicated", because Select is still the Node that we run to kick off a request for the parameters to a rule that is going to run, and in that case it isn't a root.
|
nice change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Selectsyntax in@ruledeclarations used to differentiate the declarative parameter selectors, but with the advent of coroutine@rulesand removal ofTypeConstraint, theSelectsyntax no longer has any use.Solution
Remove the
Selectsyntax for@rules, while preserving it as the marker for root selections in the graph. Update the documentation for@rulesto refer to these as "parameter selectors".