Remove un-needed travis-ci.sh ci wrapper.
#7548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prep for / broken off from #7186. |
benjyw
approved these changes
Apr 14, 2019
This was referenced Apr 14, 2019
This guarded Pants from seeing bad pyenv shims, but Pants interpreter selection has since been made robust to bad interpreters in 874ce34.
We only care that the identity (major/minor constraint really) of the current interpreter is found in the cache filter tests; we don't care about the underlying path to the interpreter, which can be muddied by pyenv shims.
jsirois
force-pushed
the
issues/6927-prep/kill-travis-ci.sh
branch
from
eefab90
to
6b0bb60
Compare
Eric-Arellano
approved these changes
Apr 14, 2019
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Apr 14, 2019
Noticed working pantsbuild#7548.
blorente
added a commit
that referenced
this pull request
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guarded Pants from seeing bad pyenv shims, but Pants interpreter
selection has since been made robust to bad interpreters in 874ce34.
That said, an overly-specific interpreter cache test is loosened to
account for path differences between pyenv shim scripts and underlying
re-directed python interpreter binary paths.