Replace the goals goal with a help plugin which supports both v1 and v2
#7598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsumes scopes as well as Goals.
stuhood
force-pushed
the
stuhood/replace-goals-task-with-help-printer
branch
from
408b9d6
to
eb5d4b9
Compare
jsirois
approved these changes
Apr 20, 2019
| from pants_test.pants_run_integration_test import PantsRunIntegrationTest | ||
|
|
||
|
|
||
| class TestListGoalsIntegration(PantsRunIntegrationTest): |
There was a problem hiding this comment.
It would be great to unit test instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #6880, there will be two types of Goals:
pants.goal.goal.Goals, registered on a singletonpants.engine.goal.Goals, registered as aScopeInfocategory via@console_rules.But
./pants goalssupports only the first form (via access to the singleton), and would need to dig deep intoself.contextin order to get access to the scope info (...like./pants optionsdoes: but that's a story for another day!).Solution
Convert
./pants goalsinto a plugin to the arg splitter, similar to./pants help. While the arg-splitter method is not incredibly scalable, it seems like it should be sufficiently scalable to support most of our "meta-goals".Result
v1 and v2 Goals are supported, we have one fewer v1 Task, and #6880 is unblocked.