Pre-filter TestTarget @union members #8368

benjyw · 2019-09-30T21:54:16Z

Allows running tests over globbed targets without erroring on
any non-test targets matched by the glob.

Provides a mechanism that any other console_rule can use for similar
effect if needed.

Allows running tests over globbed targets without erroring on any non-test targets matched by the glob. Provides a mechanism that any console_rule can use for similar effects if needed.

illicitonion · 2019-09-30T22:11:22Z

src/python/pants/rules/core/test.py

+def fast_test(console: Console, addresses: BuildFileAddresses,
+              build_config: BuildConfiguration) -> Test:
+  all_targets = yield Get(HydratedTargets, BuildFileAddresses, addresses)
+  filtered_targets = build_config.union_members(TestTarget, all_targets)


I mildly prefer:

test_results = yield [ Get(TestResult, HydratedTarget, tgt) for tgt in targets if build_config.is_union_member(TestTarget, tgt) # or tgt.adaptor ]

but not enough to argue about it if you don't :)

Can do, but each call to is_union_member would end up being a linear scan of the (probably very short) list of union members for the union base. Unless we change the data structures inside BuildConfiguration.

Oh, hm, looks like it's already an OrderedSet in practice.

And just realized we need the list of filtered targets to zip with the test_results (my current code in this PR is broken there).

benjyw · 2019-09-30T22:45:53Z

OK, pushed an update. PTAL.

stuhood · 2019-09-30T23:12:25Z

src/python/pants/rules/core/test.py

@@ -25,33 +24,37 @@ class Test(Goal):


 @console_rule
-def fast_test(console: Console, addresses: BuildFileAddresses) -> Test:
-  test_results = yield [Get(TestResult, Address, address.to_address()) for address in addresses]
+def fast_test(console: Console, targets: HydratedTargets, build_config: BuildConfiguration) -> Test:


Although this horse is already out of the barn, it would be great not to rely on the BuildConfiguration like this... there is way too much "stuff" in there, and I'd be worried about getting into a Context-has-all-of-the-things situation. The BuildConfiguration is currently injected for the purposes of options parsing (I thought here? but perhaps elsewhere), and I hope that we can shrink the requirements / surface area of those @rules over time.

"Mirror" might not be the best name, but it would be good to expose some smaller purposeful type, even if that means installing:

@rule def mirror(build_config: BuildConfiguration) -> Mirror: ..

Fixed. PTAL.

Limits the exposed surface area.

stuhood

Thanks!

src/python/pants/build_graph/build_configuration.py

src/python/pants/engine/rules.py

Eric-Arellano · 2019-10-04T18:06:07Z

src/python/pants/engine/rules.py

 from textwrap import dedent
-from typing import Any, Callable, Type, cast
+from typing import Any, Callable, Dict, Iterable, Type, cast


Bad change with Iterable. That's now overriding line 11.

stuhood · 2019-10-05T01:46:12Z

src/python/pants/rules/core/test.py

-def fast_test(console: Console, addresses: BuildFileAddresses) -> Test:
-  test_results = yield [Get(TestResult, Address, address.to_address()) for address in addresses]
+def fast_test(console: Console,
+              targets: HydratedTargets,


So, there is a minor optimization here which might not matter, but which might be worth a TODO.

The effect of moving HydratedTargets into the signature like this is that fast_test will not start running until source globs have been expanded to hydrate all targets.

The previous formulation would only parse BUILD files, and would then request a test result per Address: the effect of that was that tests might be able to start running while source glob expansion was still ongoing. To preserve that behaviour, you could request Optional.of(TestResult) or some other newtype, and have coordinator_of_tests produce that and do the filtering.

I'd also feel a little bit better about that because of the TODO/NB in coordinator_of_tests: it would be nice to have the filtering logic closer to that.

Interesting! I'll take a swipe at this tomorrow.

Actually, did it now. I like it better this way! PTAL.

Eric-Arellano · 2019-10-05T04:53:52Z

src/python/pants/rules/core/test.py

@@ -22,20 +26,25 @@ class Test(Goal):
  name = 'test'


+@dataclass


Need frozen=True

stuhood

Thanks!

Pre-filter TestTarget @union members.

8e33ec1

Allows running tests over globbed targets without erroring on any non-test targets matched by the glob. Provides a mechanism that any console_rule can use for similar effects if needed.

benjyw requested review from stuhood and illicitonion September 30, 2019 21:54

illicitonion approved these changes Sep 30, 2019

View reviewed changes

benjyw added 2 commits September 30, 2019 15:45

Address code review comments.

15c4c3a

Merge branch 'master' into test_target_selection

6720729

stuhood reviewed Sep 30, 2019

View reviewed changes

Don't use BuildConfiguration directly.

770a36c

Limits the exposed surface area.

stuhood approved these changes Oct 1, 2019

View reviewed changes

src/python/pants/build_graph/build_configuration.py Outdated Show resolved Hide resolved

src/python/pants/engine/rules.py Outdated Show resolved Hide resolved

src/python/pants/engine/rules.py Outdated Show resolved Hide resolved

stuhood reviewed Oct 1, 2019

View reviewed changes

src/python/pants/engine/rules.py Outdated Show resolved Hide resolved

benjyw added 4 commits October 1, 2019 13:28

Address code review comments.

b194f32

Merge branch 'master' into test_target_selection

8e100cd

Merge branch 'master' into test_target_selection

5b5f6de

Lint

ca465ac

Eric-Arellano approved these changes Oct 4, 2019

View reviewed changes

Merge branch 'master' into test_target_selection

c9fe6e9

stuhood reviewed Oct 5, 2019

View reviewed changes

stuhood mentioned this pull request Oct 5, 2019

Make test discovery for test_testprojects.py IT more precise #8395

Merged

benjyw added 2 commits October 4, 2019 21:30

Fix bad import collision.

7ec2092

Address code review feedback.

85d54cc

Eric-Arellano reviewed Oct 5, 2019

View reviewed changes

benjyw added 3 commits October 5, 2019 10:38

Lint fix.

8f13377

Fix tests

a6507f1

Dataclass frozen fix.

8b181b8

stuhood approved these changes Oct 5, 2019

View reviewed changes

Lint.

07281c0

benjyw merged commit 30165bb into pantsbuild:master Oct 6, 2019

benjyw deleted the test_target_selection branch October 6, 2019 00:56

stuhood mentioned this pull request Oct 8, 2019

Design v2 Target API #4535

Closed

illicitonion mentioned this pull request Oct 17, 2019

Add lint-v2 rule and implement it for Python with black. #8452

Closed

pierrechevalier83 mentioned this pull request Oct 17, 2019

Use UnionMembership to reduce coupling in fmt and lint v2 rules #8490

Closed

stuhood mentioned this pull request Dec 19, 2019

A v2 backend for generating AWS Lambdas. #8835

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pre-filter TestTarget @union members #8368

Pre-filter TestTarget @union members #8368

benjyw commented Sep 30, 2019

illicitonion Sep 30, 2019

benjyw Sep 30, 2019

benjyw Sep 30, 2019

benjyw Sep 30, 2019

benjyw commented Sep 30, 2019

stuhood Sep 30, 2019

benjyw Oct 1, 2019

stuhood left a comment

Eric-Arellano Oct 4, 2019

stuhood Oct 5, 2019

benjyw Oct 5, 2019

benjyw Oct 5, 2019

Eric-Arellano Oct 5, 2019

stuhood left a comment

		@@ -22,20 +26,25 @@ class Test(Goal):
		name = 'test'


		@dataclass

Pre-filter TestTarget @union members #8368

Pre-filter TestTarget @union members #8368

Conversation

benjyw commented Sep 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjyw commented Sep 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stuhood left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stuhood left a comment

Choose a reason for hiding this comment