Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 run #8369

Closed
wants to merge 4 commits into from
Closed

V2 run #8369

wants to merge 4 commits into from

Conversation

gshuflin
Copy link
Contributor

@gshuflin gshuflin commented Oct 1, 2019

Problem

There's no V2-engine version of the run goal.

Solution

Create a V2-engine version of the run goal.

@stuhood
Copy link
Member

stuhood commented Oct 2, 2019

Thanks!

I think that run is going to need a bit of forwards compatibility thought though: people have an expectation that the thing being run will run in the foreground in an interactive fashion.

The design doc at the top of #6004 talks about marking executed processes as "foreground", which would force them to run 1) locally rather than remotely, 2) with direct access to the console.

You might not have the time to tackle adding this "foreground" capability right now, but we should try to ensure that we have a plan for switching to that mechanism from this one.

@benjyw
Copy link
Contributor

benjyw commented Oct 2, 2019

To second Stu's comment: The user expectation is that ./pants run path/to/binary runs the entrypoint locally and in the foreground. No caching and no remoting. So if we use ExecuteProcessRequest for this, we need to do it in such a way that it's neither cached nor remoted. Is that even possible?

@stuhood
Copy link
Member

stuhood commented Oct 3, 2019

To second Stu's comment: The user expectation is that ./pants run path/to/binary runs the entrypoint locally and in the foreground. No caching and no remoting. So if we use ExecuteProcessRequest for this, we need to do it in such a way that it's neither cached nor remoted. Is that even possible?

@gshuflin is iterating on a design for this over here: https://docs.google.com/document/d/1Hn73YlhTPROlULTMa_3A-Fdv7hAPiHFII8rvXri5l7E/edit#bookmark=id.swk5himqweo4

@Eric-Arellano
Copy link
Contributor

Implemented in #8573.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants