Move PlatformConstraint to a param. #8375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrfuller
force-pushed
the
hfuller/optionable-platform-param
branch
from
bcf21e3
to
463d5eb
Compare
stuhood
reviewed
Oct 2, 2019
| ) -> Pex: | ||
| """Returns a PEX with the given requirements, optional entry point, and optional | ||
| interpreter constraints.""" | ||
|
|
||
| # ignore none constraint if some rule pushes a constraint down as none. |
There was a problem hiding this comment.
This is related to the NB below, I think? Because otherwise "unconstrained" would be ok. Should move it nearer the comment probably.
|
A general question: do we have need to actually expose the option right now? Injecting this via a |
hrfuller
force-pushed
the
hfuller/optionable-platform-param
branch
from
463d5eb
to
f0b9e87
Compare
|
Fair point. I wanted to have a way to set it so I could test it, but perhaps it should just be static for now. I'll defer to you. |
hrfuller
force-pushed
the
hfuller/optionable-platform-param
branch
from
f0b9e87
to
b0263ce
Compare
|
Superseded by Stu's recent changes to platforms, e.g. #9527. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the target platform constraint is hardcoded to be the platform pants is executed on. Before we can build rules that cross compile targets we need to let users and rules specify the value of a target platform from the CLI and for sub-graph respectively.
Solution
Make a CLI option called
--target-platformwhose default value is the current platform. Seed the rule graph with this value as a root at execution time.Result
The user can select the desired target platform for binaries and artifacts created by pants. This will only effect current and future rules which have platform dependent behavior. Cross platform rules are not effected.