Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pantsbuild.pants.testinfra in favor of pantsbuild.pants.testutil #8583

Merged
merged 5 commits into from
Nov 8, 2019

Conversation

Eric-Arellano
Copy link
Contributor

Follows up on #8400. This deprecates the old modules and updates our internal usage to use the new pants.testutil namespace.

@Eric-Arellano
Copy link
Contributor Author

Commits may be independently reviewed.

The first 3b2e166 is important to get eyes on to make sure I deprecated properly. It's not behaving as I'd expect..Running ./pants test src/python/pants/help:integration while still using the old pants_test import does not actually result in a deprecation warning. I tried having that test fail, and still nothing.

@Eric-Arellano Eric-Arellano changed the title Deprecate pantsbuild.pants.testinfra (tests/python/pants_test) in favor of pantsbuild.pants.testutil (src/python/pants/testutil) Deprecate pantsbuild.pants.testinfra in favor of pantsbuild.pants.testutil Nov 6, 2019
@Eric-Arellano Eric-Arellano merged commit fe76fd9 into pantsbuild:master Nov 8, 2019
@Eric-Arellano Eric-Arellano deleted the deprecate-testinfra branch November 8, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants