Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some test files from test_foo.py to foo_test.py #8659

Merged
merged 4 commits into from
Nov 20, 2019

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Nov 20, 2019

This allows for us to quickly see in ordered directly listings all the tests for sibling implementations, e.g. specs.py and specs_test.py.

This was the original intent of #7489.

Notably, we must name ITs foo_integration_test.py, not foo_test_integration.py, for Pytest to discover the target and for our python_tests target type to properly glob the file. This contrasts with the proposal in #7489.

@Eric-Arellano Eric-Arellano merged commit aa70d5a into pantsbuild:master Nov 20, 2019
@Eric-Arellano Eric-Arellano deleted the test-suffix branch November 20, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants