./pants --v2 export-v2 [HACKY PROTOTYPE -- NOT FOR MERGING] #8760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicexplorer
changed the title
stuhood
reviewed
Dec 11, 2019
| coursier: CoursierSubsystem, | ||
| build_root: BuildRoot, | ||
| ) -> SnapshottedResolveResult: | ||
| # TODO: figure out whether the arbitrary_root kwarg is the right way to snapshot things outside of |
There was a problem hiding this comment.
There is no safe way to do this with the engine currently, because we can't watch arbitrary paths. Perhaps after #4999
cosmicexplorer
force-pushed
the
export-classpath-v2-hacky-prototype
branch
from
72d1238 to
a601b83
Compare
10 tasks
panic at 'nested block_on: EnterError { reason: "attempted to run an executor while another executor
is already running" }', src/libcore/result.rs:1165
it's likely we'll have to make this an intrinsic!
use the new `test-thrift-gen-classpath` goal!!!
…he v2/v1 target api
the command i'm currently using is:
rm -rfv wowzer && mkdir -vp ./wowzer && PEX_IGNORE_RCFILES=true ./pants --no-process-execution-{use-local-cache,cleanup-local-dirs} --no-enable-pantsd --glob-expansion-failure=ignore --v2 export-v2 --output-dir=./wowzer --output-file=out.json :: --tag='-impossible_to_import' && wc -c out.json
cosmicexplorer
force-pushed
the
export-classpath-v2-hacky-prototype
branch
from
a601b83 to
f36a08a
Compare
This was referenced Feb 20, 2020
|
Always sad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2 engine has the potential to make running and especially re-running tasks mostly instantaneous. This is a series of somewhat-orthogonal commits to implement
resolve,gen, andexportin v2 to:This draft PR currently takes a very hacky approach to the v1/v2 target API in #4535 by literally instantiating a v1 target for every v2 target, and accessing every single property on the v1 target, including memoized properties, copying them onto the v2 target. As a result (HYPOTHESIS -- PROFILING NEEDED), it is slower to run than v1 export. We expect that we can overcome these difficulties now that we have a working prototype to kick around.
Problem
(explain the context of the problem and why you're making this change. include
references to all relevant github issues.)
Solution
(describe the modifications you've made.)
Result
(describe how your changes affect the end-user behavior of the system. this section is
optional, and should generally be summarized in the title of the pull request.)