Replace BuildFileAddress with Address for HydratedTarget and TargetAdaptor
#9100
Conversation
Eric-Arellano
requested review from
stuhood,
illicitonion,
cosmicexplorer,
codealchemy and
gshuflin
This fixes some failing tests and means we can delete the type! We keep BuildFileAddress because there are still some uses for it, such as V1.
| @@ -93,6 +93,12 @@ def _raise_did_you_mean(address_family: AddressFamily, name: str, source=None) - | |||
| ) | |||
|
|
|||
|
|
|||
| @rule | |||
| async def find_build_files(addresses: Addresses) -> BuildFileAddresses: | |||
There was a problem hiding this comment.
Do we know which codepath this will still be used in? Will probably want to confirm that we don't see a performance impact.
There was a problem hiding this comment.
It's used solely for LegacyAddressMapper, which is used by filter I think?
| @@ -519,6 +544,29 @@ def owns_any_source(legacy_target: HydratedTarget) -> bool: | |||
| return TransitiveHydratedTargets(tuple(tht.root for tht in transitive_hydrated_targets), closure) | |||
|
|
|||
|
|
|||
| @rule | |||
| async def legacy_transitive_hydrated_targets( | |||
There was a problem hiding this comment.
Should make sure we don't see a performance impact on legacy goals for this... things like dependencies, maybe.
There was a problem hiding this comment.
How can we do that? Could we possibly land this for the dev release and use Twitter's performance suite to check if there were any regressions in the dev release?
There was a problem hiding this comment.
I would love to see an upstream performance suite, personally...........
Good catch, Stu!
| @@ -519,6 +544,29 @@ def owns_any_source(legacy_target: HydratedTarget) -> bool: | |||
| return TransitiveHydratedTargets(tuple(tht.root for tht in transitive_hydrated_targets), closure) | |||
|
|
|||
|
|
|||
| @rule | |||
| async def legacy_transitive_hydrated_targets( | |||
There was a problem hiding this comment.
I would love to see an upstream performance suite, personally...........
Closes #6657. Now, the engine always uses
Addressby default, unless a rule author explicitly callsawait Get[BuildFileAddress](Address).To keep things working with V1, we introduce
LegacyHydratedTargetso that the V1 code still usesBuildFileAddress.