Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notify fs watcher to engine. #9318

Merged
merged 16 commits into from
Mar 26, 2020

Commits on Mar 20, 2020

  1. Use the notify crate to implement an InvalidationWatcher for Graph …

    …operations.
    stuhood authored and Henry Fuller committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    f07a3df View commit details
    Browse the repository at this point in the history
  2. Make watch async, and watcher log to pantsd.log.

    Relativize paths returned from notify to the build_root.
    Refactor invalidate method to be an associated method on the
    InvalidationWatcher.
    Henry Fuller committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    8bd1692 View commit details
    Browse the repository at this point in the history
  3. Respond to feedback.

    * Use spawn on io pool instead of custom future impl
    * Write python fs tests
    * Relativize paths to invalidate to build root
    * invalidate nodes with parent paths.
    * Comments
    Henry Fuller committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    a7fb332 View commit details
    Browse the repository at this point in the history
  4. Add rust test.

    Make some things public so we can use them in tests.
    Use canonical path to build root for relativizing changed paths.
    Henry Fuller committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    3bad8b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2020

  1. Refactor Python tests.

    Return watch errors as core::Failure all the way to user.
    Check notify event type when deciding whether to invalidate parents.
    Move task executor onto invalidation watcher.
    Move test_support trait impl into test_support mod.
    Henry Fuller committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    d9dd5de View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. Remove notify event specific handling. Get rid of unncessary future::…

    …lazy
    Henry Fuller committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    6dd0288 View commit details
    Browse the repository at this point in the history
  2. add warn to scandir run

    Henry Fuller committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    e916089 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. use futures lock on watcher

    Henry Fuller committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    263fc05 View commit details
    Browse the repository at this point in the history
  2. Move rust engine target directory to pants cache so it doesn't interfere

    with file watching. Format watch and nodes files.
    Henry Fuller committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    974b3ce View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Merge branch 'master' into hfuller/impl-notify-watcher

    [ci skip-jvm-tests]  # No JVM changes made.
    Henry Fuller committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    89a937f View commit details
    Browse the repository at this point in the history
  2. Revert "Move rust engine target directory to pants cache so it doesn'…

    …t interfere"
    
    This reverts commit 974b3ce.
    
    [ci skip-jvm-tests]  # No JVM changes made.
    Henry Fuller committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    3c5dc63 View commit details
    Browse the repository at this point in the history
  3. no need for futures locks anymore

    # Delete this line to force CI to run the JVM tests.
    [ci skip-jvm-tests]  # No JVM changes made.
    Henry Fuller committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    1602241 View commit details
    Browse the repository at this point in the history
  4. only watch on scandir nodes

    # Delete this line to force CI to run the JVM tests.
    [ci skip-jvm-tests]  # No JVM changes made.
    Henry Fuller committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    77f734c View commit details
    Browse the repository at this point in the history
  5. empty commit for ci trigger

    # Delete this line to force CI to run the JVM tests.
    [ci skip-jvm-tests]  # No JVM changes made.
    Henry Fuller committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    de31d18 View commit details
    Browse the repository at this point in the history
  6. remove tokio 0.1 from engine dev-dependencies

    # Delete this line to force CI to run the JVM tests.
    [ci skip-jvm-tests]  # No JVM changes made.
    Henry Fuller committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    04b8746 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Platform specific watching behavior. On Darwin recursively watch the

    build root at startup. On Linux watch individual directory roots.
    
    [ci skip-jvm-tests]  # No JVM changes made.
    Henry Fuller committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    3f52ee5 View commit details
    Browse the repository at this point in the history