-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix accidentally double-registering setuptools for ipex #9341
fix accidentally double-registering setuptools for ipex #9341
Conversation
It looks like there is one failure in a unit test that is potentially related. Is this covered by existing tests? |
2edc355
to
588edaa
Compare
The |
7c4a34e
to
c544d63
Compare
c544d63
to
b913d76
Compare
[ci skip-jvm-tests] # No JVM changes made.
0bedee0
to
8d644b0
Compare
) When creating `.ipex` files as per pantsbuild#8793, we don't add resolved distributions to `self._distributions` in `PexBuilderWrapper`. This leads to the annoying `_sanitize_requirements()` hack introduced into `ipex_launcher.py` in that PR (having to remove duplicate `setuptools` requirements). - Add all resolved distributions to `self._distributions` in `PexBuilderWrapper`, even when `generate_ipex=True`. - Remove the separate list of transitively-resolved requirements passed through several methods in `PexBuilderWrapper`.
) When creating `.ipex` files as per pantsbuild#8793, we don't add resolved distributions to `self._distributions` in `PexBuilderWrapper`. This leads to the annoying `_sanitize_requirements()` hack introduced into `ipex_launcher.py` in that PR (having to remove duplicate `setuptools` requirements). - Add all resolved distributions to `self._distributions` in `PexBuilderWrapper`, even when `generate_ipex=True`. - Remove the separate list of transitively-resolved requirements passed through several methods in `PexBuilderWrapper`.
) When creating `.ipex` files as per pantsbuild#8793, we don't add resolved distributions to `self._distributions` in `PexBuilderWrapper`. This leads to the annoying `_sanitize_requirements()` hack introduced into `ipex_launcher.py` in that PR (having to remove duplicate `setuptools` requirements). - Add all resolved distributions to `self._distributions` in `PexBuilderWrapper`, even when `generate_ipex=True`. - Remove the separate list of transitively-resolved requirements passed through several methods in `PexBuilderWrapper`.
When creating `.ipex` files as per #8793, we don't add resolved distributions to `self._distributions` in `PexBuilderWrapper`. This leads to the annoying `_sanitize_requirements()` hack introduced into `ipex_launcher.py` in that PR (having to remove duplicate `setuptools` requirements). - Add all resolved distributions to `self._distributions` in `PexBuilderWrapper`, even when `generate_ipex=True`. - Remove the separate list of transitively-resolved requirements passed through several methods in `PexBuilderWrapper`.
When creating `.ipex` files as per #8793, we don't add resolved distributions to `self._distributions` in `PexBuilderWrapper`. This leads to the annoying `_sanitize_requirements()` hack introduced into `ipex_launcher.py` in that PR (having to remove duplicate `setuptools` requirements). - Add all resolved distributions to `self._distributions` in `PexBuilderWrapper`, even when `generate_ipex=True`. - Remove the separate list of transitively-resolved requirements passed through several methods in `PexBuilderWrapper`.
### Problem When creating `.ipex` files as per #8793, we don't add resolved distributions to `self._distributions` in `PexBuilderWrapper`. This leads to the annoying `_sanitize_requirements()` hack introduced into `ipex_launcher.py` in that PR (having to remove duplicate `setuptools` requirements). ### Solution - Add all resolved distributions to `self._distributions` in `PexBuilderWrapper`, even when `generate_ipex=True`. - Remove the separate list of transitively-resolved requirements passed through several methods in `PexBuilderWrapper`.
When creating `.ipex` files as per #8793, we don't add resolved distributions to `self._distributions` in `PexBuilderWrapper`. This leads to the annoying `_sanitize_requirements()` hack introduced into `ipex_launcher.py` in that PR (having to remove duplicate `setuptools` requirements). - Add all resolved distributions to `self._distributions` in `PexBuilderWrapper`, even when `generate_ipex=True`. - Remove the separate list of transitively-resolved requirements passed through several methods in `PexBuilderWrapper`.
Problem
When creating
.ipex
files as per #8793, we don't add resolved distributions toself._distributions
inPexBuilderWrapper
. This leads to the annoying_sanitize_requirements()
hack introduced intoipex_launcher.py
in that PR (having to remove duplicatesetuptools
requirements).Solution
self._distributions
inPexBuilderWrapper
, even whengenerate_ipex=True
.PexBuilderWrapper
.