Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TargetAdaptor implementation of list with Target API implementation #9912

Merged
merged 7 commits into from
Jun 16, 2020

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented May 30, 2020

This improves performance because we no longer use HydratedTarget, meaning that we no longer need to hydrate the source files.

We keep the original integration tests - those should work regardless of V1 vs. V2.

…plementation

# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@Eric-Arellano Eric-Arellano changed the title Replace V1 implementations of list, dependees, and dependencies with V2 implementations Replace TargetAdaptor implementation of list with Target API implementation Jun 15, 2020
@Eric-Arellano
Copy link
Contributor Author

Reverted the changes for dependees and dependencies because I couldn't get things working properly with synthetic targets. Don't think we can remove the v1 goals until 2.0 :/

@Eric-Arellano Eric-Arellano merged commit e7bdc6a into pantsbuild:master Jun 16, 2020
@Eric-Arellano Eric-Arellano deleted the replace-list branch June 16, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants